Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-06-30 Thread Felipe Balbi
Michał Mirosław writes: > On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: >> >> > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > > unsigned >> > intf, unsigned alt) >> > > >/* we know alt == 0, so this is an activation or a reset */ >> > > >

RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-06-30 Thread Felipe Balbi
Peter Chen writes: > >> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > unsigned >> intf, unsigned alt) >> > > /* we know alt == 0, so this is an activation or a reset */ >> > > >> > > if (intf == acm->ctrl_id) { >> > > -dev_vdbg

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-31 Thread Peter Chen
On 20-05-30 19:15:52, Michał Mirosław wrote: > On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: > > > > > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, > > > > > unsigned > > > intf, unsigned alt) > > > > > /* we know alt == 0, so this is an activation

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-30 Thread Michał Mirosław
On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: > > > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, > > > > unsigned > > intf, unsigned alt) > > > > /* we know alt == 0, so this is an activation or a reset */ > > > > > > > > if (intf == acm->

RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-29 Thread Peter Chen
> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, > > > unsigned > intf, unsigned alt) > > > /* we know alt == 0, so this is an activation or a reset */ > > > > > > if (intf == acm->ctrl_id) { > > > - dev_vdbg(&cdev->gadget->dev, > > > -

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-29 Thread Michał Mirosław
On Fri, May 29, 2020 at 08:10:40AM +, Peter Chen wrote: > On 20-05-28 20:30:28, Michał Mirosław wrote: > > Make debugging real problems easier by not trying to disable an EP that > > was not yet enabled. > > > > Fixes: 4aab757ca44a ("usb: gadget: f_acm: eliminate abuse of ep->driver > > data"

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-29 Thread Peter Chen
On 20-05-28 20:30:28, Michał Mirosław wrote: > Make debugging real problems easier by not trying to disable an EP that > was not yet enabled. > > Fixes: 4aab757ca44a ("usb: gadget: f_acm: eliminate abuse of ep->driver data") > Signed-off-by: Michał Mirosław > --- > drivers/usb/gadget/function/f_