Re: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs

2012-07-26 Thread Ingo Molnar
* Tomoki Sekiyama wrote: > In current Linux, percpu variable `vector_irq' is not always cleared when > a CPU is offlined. If the CPU that has the disabled irqs in vector_irq is > hotplugged again, __setup_vector_irq() hits invalid irq vector and may > crash. > > This bug can be reproduced as fo

Re: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs

2012-07-26 Thread Tomoki Sekiyama
Hi, thanks for your comment. On 2012/07/26 8:28, Siddha, Suresh B wrote: > Tomoki wrote: >> In current Linux, percpu variable `vector_irq' is not always cleared when >> a CPU is offlined. If the cpu that has the disabled irqs in vector_irq is >> hotplugged again, __setup_vector_irq() hits invalid

RE: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs

2012-07-25 Thread Siddha, Suresh B
Tomoki wrote: > In current Linux, percpu variable `vector_irq' is not always cleared when > a CPU is offlined. If the cpu that has the disabled irqs in vector_irq is > hotplugged again, __setup_vector_irq() hits invalid irq vector and may > crash. > > Commit f6175f5bfb4c partially fixes this, but w