Re: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq

2012-10-16 Thread Yinghai Lu
On Tue, Oct 16, 2012 at 8:36 PM, Liu, Chuansheng wrote: >> So we can use generic list helper function. > Does it really need the generic list with both prev and next pointers? > For irq_2_pin list, the next pointer seems be enough. generic version should be always better than home grown one. -- T

RE: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq

2012-10-16 Thread Liu, Chuansheng
> Subject: Re: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq > > On Wed, Oct 17, 2012 at 3:11 AM, Chuansheng Liu > wrote: > > > > When destroying the irq, before free cfg, need to check > > cfg->irq_2_pin and free it when it is not NULL. > >

Re: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq

2012-10-16 Thread Yinghai Lu
On Wed, Oct 17, 2012 at 3:11 AM, Chuansheng Liu wrote: > > When destroying the irq, before free cfg, need to check > cfg->irq_2_pin and free it when it is not NULL. > > Signed-off-by: liu chuansheng > --- i had that in another patch... https://lkml.org/lkml/2012/2/23/574 Subject [PATCH 01