RE: [PATCH] x86: Re-enable IO-APIC for non-SMP X86_32

2015-01-29 Thread Ong, Boon Leong
Tested this patch together with following v6 patch for Quark IMR: 1) x86: Add Isolated Memory Regions for Quark X1000 2) x86, quark: Add Intel Quark platform support Built and tested on Galileo Genv2. This patch looks good. I will give you my tested-by below. Thanks! >-Original Message

Re: [PATCH] x86: Re-enable IO-APIC for non-SMP X86_32

2015-01-22 Thread Bryan O'Donoghue
On 22/01/15 21:42, Thomas Gleixner wrote: config X86_UP_APIC bool "Local APIC support on uniprocessors" - depends on X86_32 && !SMP && !X86_32_NON_STANDARD && !PCI_MSI + depends on X86_32 && !SMP && !X86_32_NON_STANDARD ---help--- A local APIC (Advanced Pro

Re: [PATCH] x86: Re-enable IO-APIC for non-SMP X86_32

2015-01-22 Thread Thomas Gleixner
On Thu, 22 Jan 2015, Bryan O'Donoghue wrote: > Commit 0dbc6078c0 ('x86, build, pci: Fix PCI_MSI build on !SMP') > introduced the dependency that X86_UP_APIC should only be visible only when > PCI_MSI is false. I think the intention of the patch was to NOT expose the option when MSI is enabled, so

Re: [PATCH] x86: Re-enable IO-APIC for non-SMP X86_32

2015-01-22 Thread Andy Shevchenko
On Thu, Jan 22, 2015 at 10:53 PM, Bryan O'Donoghue wrote: [] > Since Intel-CE, Intel-Mid and Intel-Quark are all 32-bit uniprocessor I can hardly tell that Intel MID is UP systems. No dashes, please :-) Otherwise Reviewed-by: Andy Shevchenko > systems with an IO-APIC re-enabling IO-APIC fo