Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread H. Peter Anvin
[EMAIL PROTECTED] wrote: The ones in /proc/cpuinfo are cooked values anyway; there is plenty of history to that effect. I don't know this history. And I don't care. I thought /proc/cpuinfo should show an (almost) complete list of CPU features. If this is not the case it's a pity. It's a li

RE: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread aherrman
Peter Anvin wrote: > Andreas Herrmann wrote: > > > > It is not equivalent. Usually users check /proc/cpuinfo for their > > CPU features. Deleting that flag is kind of obfuscation. > > > > I guess some time ago people did not care about their "svm" or "vmx" > > flags. Nowadays (e.g. with kvm) some

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread H. Peter Anvin
Markus Rechberger wrote: please see: http://kvm.qumranet.com/kvmwiki/FAQ "How can I tell if I have Intel VT or AMD-V?" Yes, what's your point? -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Markus Rechberger
H. Peter Anvin wrote: Andreas Herrmann wrote: It is not equivalent. Usually users check /proc/cpuinfo for their CPU features. Deleting that flag is kind of obfuscation. I guess some time ago people did not care about their "svm" or "vmx" flags. Nowadays (e.g. with kvm) some people are quite ha

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andi Kleen
On Thursday 05 April 2007 18:20:49 Andreas Herrmann wrote: > On Thu, Apr 05, 2007 at 05:37:17PM +0200, Andi Kleen wrote: > > > > > > > This patch will enable default_idle for non-Intel > > > > > CPUs even if mwait is supported. > > > > > > > > It would be better to clear MONITOR/MWAIT in the AMD

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread H. Peter Anvin
Andreas Herrmann wrote: It is not equivalent. Usually users check /proc/cpuinfo for their CPU features. Deleting that flag is kind of obfuscation. I guess some time ago people did not care about their "svm" or "vmx" flags. Nowadays (e.g. with kvm) some people are quite happy if one of those str

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 05:37:17PM +0200, Andi Kleen wrote: > > > > > This patch will enable default_idle for non-Intel > > > > CPUs even if mwait is supported. > > > > > > It would be better to clear MONITOR/MWAIT in the AMD specific > > > CPU initialize code than add workarounds everywhere else

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andi Kleen
> > > This patch will enable default_idle for non-Intel > > > CPUs even if mwait is supported. > > > > It would be better to clear MONITOR/MWAIT in the AMD specific > > CPU initialize code than add workarounds everywhere else. > > Why is that? > MONITOR/MWAIT is usable. If it doesn't save power

RE: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Langsdorf, Mark
> > Commit 991528d7348667924176f3e29addea0675298944 > > introduced mwait_idle which is supposed to work > > for Intel CPUs starting with Core Duo. > > > > AMD Fam10 processors won't enter C1 on mwait. > > Unfortunate. Will this be fixed? Fam10 processors were not designed to enter C1 on mwait. T

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 04:24:45PM +0200, Andi Kleen wrote: > On Thursday 05 April 2007 16:00:45 Andreas Herrmann wrote: > > > > Commit 991528d7348667924176f3e29addea0675298944 > > introduced mwait_idle which is supposed to work > > for Intel CPUs starting with Core Duo. > > > > AMD Fam10 process

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andi Kleen
On Thursday 05 April 2007 16:00:45 Andreas Herrmann wrote: > > Commit 991528d7348667924176f3e29addea0675298944 > introduced mwait_idle which is supposed to work > for Intel CPUs starting with Core Duo. > > AMD Fam10 processors won't enter C1 on mwait. Unfortunate. Will this be fixed? > This pat