Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-11 Thread Heikki Krogerus
Hi Noam, On Thu, Dec 10, 2015 at 04:33:39PM +, Noam Camus wrote: > Please see > https://lkml.org/lkml/2015/8/3/806 > Why I added private accessors. Greg is not saying anything about the iotype checking there? Looks more like confusion about what exactly is that patch trying to achieve. I

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-11 Thread Heikki Krogerus
Hi Noam, On Thu, Dec 10, 2015 at 04:33:39PM +, Noam Camus wrote: > Please see > https://lkml.org/lkml/2015/8/3/806 > Why I added private accessors. Greg is not saying anything about the iotype checking there? Looks more like confusion about what exactly is that patch trying to achieve. I

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-10 Thread Heikki Krogerus
On Thu, Dec 10, 2015 at 11:31:04AM +0200, Heikki Krogerus wrote: > Hi Noam, > > On Thu, Dec 10, 2015 at 07:26:42AM +, Noam Camus wrote: > > >From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > > >Sent: Wednesday, December 09, 2015 3:20 PM > > > > > > >> @@ -171,7 +174,8 @@

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-10 Thread Heikki Krogerus
Hi Noam, On Thu, Dec 10, 2015 at 07:26:42AM +, Noam Camus wrote: > >From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > >Sent: Wednesday, December 09, 2015 3:20 PM > > > >> @@ -171,7 +174,8 @@ static void dw8250_serial_out32(struct uart_port *p, > >> int offset, int value) >

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-10 Thread Heikki Krogerus
Hi Noam, On Thu, Dec 10, 2015 at 07:26:42AM +, Noam Camus wrote: > >From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > >Sent: Wednesday, December 09, 2015 3:20 PM > > > >> @@ -171,7 +174,8 @@ static void dw8250_serial_out32(struct uart_port *p, > >> int offset, int value) >

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-10 Thread Heikki Krogerus
On Thu, Dec 10, 2015 at 11:31:04AM +0200, Heikki Krogerus wrote: > Hi Noam, > > On Thu, Dec 10, 2015 at 07:26:42AM +, Noam Camus wrote: > > >From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > > >Sent: Wednesday, December 09, 2015 3:20 PM > > > > > > >> @@ -171,7 +174,8 @@

RE: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Noam Camus
>From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] >Sent: Wednesday, December 09, 2015 3:20 PM >> @@ -171,7 +174,8 @@ static void dw8250_serial_out32(struct uart_port *p, int >> offset, int value) >> if ((value & ~UART_LCR_SPAR) == (lcr & ~UART_LCR_SPAR)) >>

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Heikki Krogerus
On Wed, Dec 09, 2015 at 03:19:39PM +0200, Heikki Krogerus wrote: > Hi Noam, > > On Sun, Oct 18, 2015 at 12:01:48PM +0300, Noam Camus wrote: > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index a0cdbf3..880f712 100644 > > ---

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Heikki Krogerus
Hi Noam, On Sun, Oct 18, 2015 at 12:01:48PM +0300, Noam Camus wrote: > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index a0cdbf3..880f712 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -63,6 +63,9 @@

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Heikki Krogerus
On Wed, Dec 09, 2015 at 03:19:39PM +0200, Heikki Krogerus wrote: > Hi Noam, > > On Sun, Oct 18, 2015 at 12:01:48PM +0300, Noam Camus wrote: > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index a0cdbf3..880f712 100644 > > ---

Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Heikki Krogerus
Hi Noam, On Sun, Oct 18, 2015 at 12:01:48PM +0300, Noam Camus wrote: > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index a0cdbf3..880f712 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -63,6 +63,9 @@

RE: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses

2015-12-09 Thread Noam Camus
>From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] >Sent: Wednesday, December 09, 2015 3:20 PM >> @@ -171,7 +174,8 @@ static void dw8250_serial_out32(struct uart_port *p, int >> offset, int value) >> if ((value & ~UART_LCR_SPAR) == (lcr & ~UART_LCR_SPAR)) >>