Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-22 Thread Jarkko Sakkinen
On Wed, Dec 20, 2017 at 12:43:39PM +0100, Hans de Goede wrote: > Note I'm just reading along here, but I'm wondering if both the TPM > and now also some PS/2 controllers need CLK_RUN to be disabled, > why don't we just disable it once permanently and be done with it? > > It seems that on machines

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread Jeffery Miller
On Thu, Dec 21, 2017 at 12:44 PM, Javier Martinez Canillas wrote: > Hello Jeffery, > Can I add your Tested-by tag then? Yes you can. tested-by: Jeffery Miller Thanks, Jeff

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread Javier Martinez Canillas
Hello Jeffery, On 12/21/2017 06:25 PM, Jeffery Miller wrote: > On Thu, Dec 21, 2017 at 6:46 AM, Javier Martinez Canillas > wrote: >> >> I meant linux-tpmdd + the 4 patches in this series. > > Javier, > I applied the four patches to the linux-tpmdd master 46dd3b29e328 this > morning and it > fixe

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread Jeffery Miller
On Thu, Dec 21, 2017 at 6:46 AM, Javier Martinez Canillas wrote: > > I meant linux-tpmdd + the 4 patches in this series. Javier, I applied the four patches to the linux-tpmdd master 46dd3b29e328 this morning and it fixed the touchpad on my affected machine. To be clear, the patchwork patches I a

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread Javier Martinez Canillas
Hello James, On 12/21/2017 11:51 AM, James Ettle wrote: > OK, I built a kernel based on: > > - git clone of git.infradead.org/users/jjs/linux-tpmdd.git taken last night > - applying the patch in https://patchwork.kernel.org/patch/10119417/ I meant linux-tpmdd + the 4 patches in this series. > -

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread James Ettle
OK, I built a kernel based on: - git clone of git.infradead.org/users/jjs/linux-tpmdd.git taken last night - applying the patch in https://patchwork.kernel.org/patch/10119417/ - stock config-4.14.6-300.fc27.x86_64 + make oldconfig The tpm modules are loaded and the keyboard is working. Note: I w

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Javier Martinez Canillas
On 12/20/2017 06:44 PM, Jason Gunthorpe wrote: > On Wed, Dec 20, 2017 at 05:45:16PM +0100, Javier Martinez Canillas wrote: > >> CHP51 says "LPC Clock Control Using the LPC_CLKRUN# May Not Behave As >> Expected" >> and that the implication is that "The SoC may prevent a peripheral device >> from

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Jason Gunthorpe
On Wed, Dec 20, 2017 at 05:45:16PM +0100, Javier Martinez Canillas wrote: > CHP51 says "LPC Clock Control Using the LPC_CLKRUN# May Not Behave As > Expected" > and that the implication is that "The SoC may prevent a peripheral device from > successfully requesting the LPC clock". Now we are back

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Javier Martinez Canillas
; hdego...@redhat.com; linux- >> ker...@vger.kernel.org >> Cc: ja...@ettle.org.uk; a...@arndb.de; jarkko.sakki...@linux.intel.com; >> peterhu...@gmx.de; j...@ziepe.ca; gre...@linuxfoundation.org; linux- >> integr...@vger.kernel.org >> Subject: Re: [PATCH 0/4] tpm: fix

RE: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Shaikh, Azhar
rndb.de; jarkko.sakki...@linux.intel.com; >peterhu...@gmx.de; j...@ziepe.ca; gre...@linuxfoundation.org; linux- >integr...@vger.kernel.org >Subject: Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell >systems due CLKRUN enabled > >Hello Azhar, > >On 12/20

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Javier Martinez Canillas
Hello Azhar, On 12/20/2017 04:08 PM, Shaikh, Azhar wrote: [snip] >>> It seems that on machines with a PS/2 controller connected to the LPC bus the BIOS is already doing this, so I've a feeling that it not being done on devices with a TPM is a bug in the firmware >>> >>> Absolutely

RE: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Shaikh, Azhar
kernel.org >Cc: ja...@ettle.org.uk; Shaikh, Azhar ; >a...@arndb.de; jarkko.sakki...@linux.intel.com; peterhu...@gmx.de; >j...@ziepe.ca; gre...@linuxfoundation.org; linux-integr...@vger.kernel.org >Subject: RE: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell >system

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Javier Martinez Canillas
Hello Alexander, On 12/20/2017 03:07 PM, alexander.stef...@infineon.com wrote: >> Hi Hans, >> >> Thanks a lot for your feedback. >> >> On 12/20/2017 12:43 PM, Hans de Goede wrote: >>> Hi, >>> >>> On 20-12-17 12:35, Javier Martinez Canillas wrote: Hello, Commit 5e572cab92f0 ("tpm: En

RE: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Alexander.Steffen
> Hi Hans, > > Thanks a lot for your feedback. > > On 12/20/2017 12:43 PM, Hans de Goede wrote: > > Hi, > > > > On 20-12-17 12:35, Javier Martinez Canillas wrote: > >> Hello, > >> > >> Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell > systems") > >> added logic in the TPM TIS drive

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Javier Martinez Canillas
Hi Hans, Thanks a lot for your feedback. On 12/20/2017 12:43 PM, Hans de Goede wrote: > Hi, > > On 20-12-17 12:35, Javier Martinez Canillas wrote: >> Hello, >> >> Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems") >> added logic in the TPM TIS driver to disable the Low Pin

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-20 Thread Hans de Goede
Hi, On 20-12-17 12:35, Javier Martinez Canillas wrote: Hello, Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems") added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN signal during TPM transactions. Unfortunately this breaks other devices that are attached