Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-28 Thread Joe Perches
On Tue, 2016-03-29 at 05:37 +, Zheng, Lv wrote: > Hi, Hi again. > > No, I disagree.  _I_ don't need to.  You need to. > [Lv Zheng]  > Then you don't have to provide the solution as you are not the one executing > the process. > I can fix it myself: > https://github.com/acpica/acpica/pull/129 

RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-28 Thread Zheng, Lv
Hi, > From: Joe Perches [mailto:j...@perches.com] > Subject: Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 > release > > On Mon, 2016-03-28 at 03:02 +, Zheng, Lv wrote: > > Hi, > > Hello. > > > > So why not fix the process scrip

Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-27 Thread Joe Perches
On Mon, 2016-03-28 at 03:02 +, Zheng, Lv wrote: > Hi, Hello. > > So why not fix the process script first? > > Maybe add something like: > > $ grep -E "^typedef\s+\w+\s*\*?\s*acpi_\w+" include/acpi/actypes.h | \ > >   grep -Eoh "\bacpi_\w+" > > > > to the acpi_types variable in the lindent_si

RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-27 Thread Zheng, Lv
Hi, > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > Subject: Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 > release > > On Thu, 2016-03-24 at 06:19 +, Zheng, Lv wrote: > > From: Joe Perches [mailto:j...@perches.com] > >

Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-24 Thread Joe Perches
On Thu, 2016-03-24 at 06:19 +, Zheng, Lv wrote: > From: Joe Perches [mailto:j...@perches.com] > > Subject: Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 > > release > > > > On Thu, 2016-03-24 at 09:38 +0800, Lv Zheng wrote: > > >

RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-23 Thread Zheng, Lv
Hi, > From: Brown, Len > Subject: RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 > release > > > > > > > > > -acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address > > *reg) > > > > +acpi_status acpi_hw_

RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-23 Thread Brown, Len
> > > > > > -acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address > *reg) > > > +acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address * > reg) > > > > The second argument * style appears the opposite of normal style > > and a different style than the first argument * style.

RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-23 Thread Zheng, Lv
Hi, First, thanks for the revew. > From: Joe Perches [mailto:j...@perches.com] > Subject: Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 > release > > On Thu, 2016-03-24 at 09:38 +0800, Lv Zheng wrote: > > The patch reduces source code differences bet

Re: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release

2016-03-23 Thread Joe Perches
On Thu, 2016-03-24 at 09:38 +0800, Lv Zheng wrote: > The patch reduces source code differences between the Linux kernel and the > ACPICA upstream so that the linuxized ACPICA 20160212 release can be > applied with reduced human intervention. In the very first patch fragment: > diff --git a/driver