RE: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Chrzaniuk, Hubert
On Wed, Aug 03, 2016 at 07:06:56AM +, Chrzaniuk, Hubert wrote: >> The original patch has been prepared by Lukas, then I [Hubert] rebased >> it, added commentary and cleaned up the code. In the end, Lukas >> modified it a bit once again according to suggestions from Tony. My >> SOB is unneces

RE: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Chrzaniuk, Hubert
On Wed, Aug 03, 2016 at 09:25:13AM +, Chrzaniuk, Hubert wrote: >> Thanks a lot, next time I am gonna do it the right way from the begging :) > Does "next time" mean you guys will be introducing more bugs to sb_edac? > :- I try to maintain my job security in other ways, introducing bugs on

Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Borislav Petkov
On Wed, Aug 03, 2016 at 09:25:13AM +, Chrzaniuk, Hubert wrote: > Thanks a lot, next time I am gonna do it the right way from the begging :) Does "next time" mean you guys will be introducing more bugs to sb_edac? :- -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you re

RE: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Chrzaniuk, Hubert
On Wednesday, August 3, 2016 10:55 AM, Borislav Petkov wrote: > ...and so I did simplify it a bit more. [..] Thanks a lot, next time I am gonna do it the right way from the begging :)

Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Borislav Petkov
On Wed, Aug 03, 2016 at 09:58:38AM +0200, Borislav Petkov wrote: > "Simple" is my speciality! :-))) ...and so I did simplify it a bit more. Here's the final result: --- From: Lukasz Odzioba Date: Sat, 23 Jul 2016 01:44:49 +0200 Subject: [PATCH] EDAC, sb_edac: Fix channel reporting on Knights Lan

Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Borislav Petkov
On Wed, Aug 03, 2016 at 07:44:22AM +, Chrzaniuk, Hubert wrote: > What you have suggested is simple and perfect, let’s leave it this way :) "Simple" is my speciality! :-))) Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --

Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Borislav Petkov
On Wed, Aug 03, 2016 at 07:06:56AM +, Chrzaniuk, Hubert wrote: > The original patch has been prepared by Lukas, then I [Hubert] rebased > it, added commentary and cleaned up the code. In the end, Lukas > modified it a bit once again according to suggestions from Tony. My > SOB is unnecessary he

RE: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-03 Thread Chrzaniuk, Hubert
From: Borislav Petkov [mailto:b...@alien8.de] > What is that SOB supposed to mean? The original patch has been prepared by Lukas, then I [Hubert] rebased it, added commentary and cleaned up the code. In the end, Lukas modified it a bit once again according to suggestions from Tony. My SOB is un

Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-08-02 Thread Borislav Petkov
On Sat, Jul 23, 2016 at 01:44:49AM +0200, Lukasz Odzioba wrote: > On Intel Xeon Phi Knights Landing processor family the channels > of memory controller have untypical arrangement - MC0 is mapped to > CH3,4,5 and MC1 is mapped to CH0,1,2. This causes EDAC driver to > report the channel name incorre

RE: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing

2016-07-28 Thread Odzioba, Lukasz
On Saturday, July 23, 2016 1:45 AM, Lukasz Odzioba wrote: > On Intel Xeon Phi Knights Landing processor family the channels > of memory controller have untypical arrangement - MC0 is mapped to > CH3,4,5 and MC1 is mapped to CH0,1,2. This causes EDAC driver to > report the channel name incorrectly.