RE: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-18 Thread Liang, Kan
Hi all, There is confusion about the usage of format for me. E.g. The event config is not continuous for uncore. cat /sys/devices/uncore_qpi_0/format/event config:0-7,21 I once thought that the user input should be uncore_qpi_0/event=0x200038,/ So I submitted this patch and previous patch

RE: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-18 Thread Liang, Kan
Hi all, There is confusion about the usage of format for me. E.g. The event config is not continuous for uncore. cat /sys/devices/uncore_qpi_0/format/event config:0-7,21 I once thought that the user input should be uncore_qpi_0/event=0x200038,/ So I submitted this patch and previous patch

RE: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-04 Thread Liang, Kan
> On Mon, Apr 04, 2016 at 06:12:54AM -0700, kan.li...@intel.com wrote: > > From: Kan Liang > > > > The calculation of format value also rely on the continuity of the > > format. However, uncore event format is not continuous. > > E.g. The bit 21 as qpi event is lost. > > > >

RE: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-04 Thread Liang, Kan
> On Mon, Apr 04, 2016 at 06:12:54AM -0700, kan.li...@intel.com wrote: > > From: Kan Liang > > > > The calculation of format value also rely on the continuity of the > > format. However, uncore event format is not continuous. > > E.g. The bit 21 as qpi event is lost. > > > > perf stat -a -e

Re: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-04 Thread Jiri Olsa
On Mon, Apr 04, 2016 at 06:12:54AM -0700, kan.li...@intel.com wrote: > From: Kan Liang > > The calculation of format value also rely on the continuity of the > format. However, uncore event format is not continuous. > E.g. The bit 21 as qpi event is lost. > > perf stat -a

Re: [PATCH 1/1] perf tools: Fix format value calculation

2016-04-04 Thread Jiri Olsa
On Mon, Apr 04, 2016 at 06:12:54AM -0700, kan.li...@intel.com wrote: > From: Kan Liang > > The calculation of format value also rely on the continuity of the > format. However, uncore event format is not continuous. > E.g. The bit 21 as qpi event is lost. > > perf stat -a -e