Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Thierry Reding
On Tue, Mar 05, 2013 at 01:59:06PM +0900, Alex Courbot wrote: > On 03/05/2013 01:48 PM, Andrew Chew wrote: > >I sent out a new patch that enables/disables the backlight enable gpio. > > > >>On 03/05/2013 01:00 PM, Andrew Chew wrote: > >>>I did come to the same conclusion regarding the platform data

Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Alex Courbot
On 03/05/2013 01:59 PM, Alex Courbot wrote: Btw, you also want to check if the enable-gpio property exists first because otherwise probe() will fails if no GPIO is specified). That's actually not true - I overlooked the fact that probe() checks for the GPIO validity before requesting it. My ba

Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Alex Courbot
On 03/05/2013 01:48 PM, Andrew Chew wrote: I sent out a new patch that enables/disables the backlight enable gpio. On 03/05/2013 01:00 PM, Andrew Chew wrote: I did come to the same conclusion regarding the platform data breakage. I'm expecting that the use of platform data will go away, at lea

RE: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Andrew Chew
I sent out a new patch that enables/disables the backlight enable gpio. > On 03/05/2013 01:00 PM, Andrew Chew wrote: > > I did come to the same conclusion regarding the platform data breakage. > > I'm expecting that the use of platform data will go away, at least on > > ARM, since we are all aggre

Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Alex Courbot
On 03/05/2013 01:00 PM, Andrew Chew wrote: I did come to the same conclusion regarding the platform data breakage. I'm expecting that the use of platform data will go away, at least on ARM, since we are all aggressively moving what used to be in platform data into the device tree. Do other platf

RE: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Andrew Chew
> From: Alex Courbot > Sent: Monday, March 04, 2013 7:00 PM > To: Thierry Reding > Cc: Andrew Chew; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO > > On 03/05/2013 07:46 AM, Thierry Reding wrote: > > * PGP Signed b

Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Alex Courbot
On 03/05/2013 07:46 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, Mar 04, 2013 at 01:49:49PM -0800, Andrew Chew wrote: The backlight enable GPIO is specified in the device tree node for backlight. Signed-off-by: Andrew Chew --- .../bindings/video/backlight/pwm-backlight.t

Re: [PATCH 1/1] pwm_bl: Add support for backlight enable GPIO

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 01:49:49PM -0800, Andrew Chew wrote: > The backlight enable GPIO is specified in the device tree node for > backlight. > > Signed-off-by: Andrew Chew > --- > .../bindings/video/backlight/pwm-backlight.txt |2 ++ > drivers/video/backlight/pwm_bl.c