randeburg, Jesse; Kok, Auke; Ronciak, John
> Subject: Re: [PATCH 1/2] NET: Multiple queue network device support
>
> On 09-03-2007 14:40, Thomas Graf wrote:
> > * Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09
> >> diff --git a/net/core/dev.c b/net/core/dev.c index
On 09-03-2007 14:40, Thomas Graf wrote:
> * Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 455d589..42b635c 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -1477,6 +1477,49 @@ gso:
>> skb->tc_verd = SET_TC_AT(skb->tc_verd,AT
, Auke; Ronciak, John
> Subject: Re: [PATCH 1/2] NET: Multiple queue network device support
>
> * Waskiewicz Jr, Peter P <[EMAIL PROTECTED]>
> 2007-03-09 15:27
> > That's the entire point of this extra locking. enqueue()
> is going to
> > put an skb int
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-03-09 15:27
> That's the entire point of this extra locking. enqueue() is going to
> put an skb into a band somewhere that maps to some queue, and there is
> no way to guarantee the skb I retrieve from dequeue() is headed for the
> same queue. The
> * Waskiewicz Jr, Peter P <[EMAIL PROTECTED]>
> 2007-03-09 11:25
> > > > + }
> > > > + } else {
> > > > + /* We're not a multi-queue device. */
> > > > + spin_lock(&dev->queue_lock);
> > > > + q
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-03-09 11:25
> > > + }
> > > + } else {
> > > + /* We're not a multi-queue device. */
> > > + spin_lock(&dev->queue_lock);
> > > + q = dev->qdisc;
> > > + if (q->
, Auke; Ronciak, John
> Subject: Re: [PATCH 1/2] NET: Multiple queue network device support
>
> * Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09
> > diff --git a/net/core/dev.c b/net/core/dev.c index 455d589..42b635c
> > 100644
> > --- a/net/core/dev.c
&
* Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 455d589..42b635c 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1477,6 +1477,49 @@ gso:
> skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_EGRESS);
> #endif
> if (q->enqueue) {
>
On 07-03-2007 23:42, David Miller wrote:
> I didn't say to use skb->priority, I said to shrink skb->priority down
> to a u16 and then make another u16 which will store your queue mapping
> value.
Peter is right: this is fully used by schedulers (prio,
CBQ, HTB, HFSC...) and would break users' scri
I didn't say to use skb->priority, I said to shrink skb->priority down
to a u16 and then make another u16 which will store your queue mapping
value.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
IL PROTECTED]
> Sent: Monday, February 26, 2007 5:03 PM
> To: Kok, Auke-jan H
> Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Waskiewicz Jr, Peter P;
> Brandeburg, Jesse; [EMAIL PROTECTED]; Ronciak, John
> Subject: Re: [PATCH 1/2] NET: Multiple
Dave,
Thanks for the feedback. Please see below for my comments /
questions.
PJ Waskiewicz
Intel Corporation
> > From: Peter Waskiewicz Jr <[EMAIL PROTECTED]>
> >
> > Added an API and associated supporting routines for
> multiqueue network
> > devices. This allows network devices sup
From: "Kok, Auke" <[EMAIL PROTECTED]>
Date: Thu, 08 Feb 2007 16:09:50 -0800
> From: Peter Waskiewicz Jr <[EMAIL PROTECTED]>
>
> Added an API and associated supporting routines for multiqueue network
> devices. This allows network devices supporting multiple TX queues to
> configure each queue wi
Stephen Hemminger wrote:
On Fri, 23 Feb 2007 04:00:55 -0500
"Sreenivasa Honnur" <[EMAIL PROTECTED]> wrote:
Fucntion "map_queue" returns queue index as '0'. There is no support to
return different queue indexes.
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Beh
On Fri, 23 Feb 2007 04:00:55 -0500
"Sreenivasa Honnur" <[EMAIL PROTECTED]> wrote:
> Fucntion "map_queue" returns queue index as '0'. There is no support to
> return different queue indexes.
>
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> On Behalf Of Kok, Auke
g
> Cc: Waskiewicz Jr, Peter P; Brandeburg, Jesse; Kok, Auke;
> Ronciak, John
> Subject: RE: [PATCH 1/2] NET: Multiple queue network device support
>
> Fucntion "map_queue" returns queue index as '0'. There is no
> support to return different queue indexes.
Fucntion "map_queue" returns queue index as '0'. There is no support to
return different queue indexes.
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Kok, Auke
Sent: Friday, February 09, 2007 5:40 AM
To: David Miller; Garzik, Jeff; netdev@vger.kernel.org
Function "map_queue" returns queue_index as 0 always. There is no
support to return different queue numbers.
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Kok, Auke
Sent: Friday, February 09, 2007 5:40 AM
To: David Miller; Garzik, Jeff; netdev@vger.kerne
18 matches
Mail list logo
