Re: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-25 Thread srinivas pandruvada
Hi Doug, On Thu, 2020-06-25 at 07:59 -0700, Doug Smythies wrote: > Hi Srinivas, > > I saw your V3. > I do not understand your reluctance to use > > arch/x86/include/asm/msr-index.h I don't have reluctance. That was the guidance from x86 core maintainers years back. But may have changed. So

RE: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-25 Thread Doug Smythies
Hi Srinivas, I saw your V3. I do not understand your reluctance to use arch/x86/include/asm/msr-index.h as the place to define anything MSR related. Please explain. One more comment about 1/3 of the way down below. ... Doug On 2020.06.23 08:53 Doug Smythies wrote: > On 2020.06.22 22:13

RE: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-23 Thread Doug Smythies
On 2020.06.22 22:13 Srinivas Pandruvada wrote: > By default intel_pstate driver disables energy efficiency by setting > MSR_IA32_POWER_CTL bit 19 for Kaby Lake desktop CPU model in HWP mode. > This CPU model is also shared by Coffee Lake desktop CPUs. This allows > these systems to reach maximum