Re: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-21 Thread Xu Yilun
Sorry, I missed some comments. Reply inline. > > + /* release I/O mappings for next step enumeration */ > > + cci_pci_iounmap_bars(pcidev, mapped_bars); > There is no iounmap_bars in error handling, likely need to add this. The memory allocated by pcim_iomap_xxx will be released along with pc

Re: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-21 Thread Xu Yilun
On Mon, Jul 20, 2020 at 05:09:35PM +0800, Wu, Hao wrote: > > Subject: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own > > feature drivers > > > > This patch makes preparation for modularization of DFL sub feature > > drivers. > > > > Currently, if we need to support a new DFL sub fea

Re: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-21 Thread Xu Yilun
On Fri, Jul 17, 2020 at 09:51:34AM -0700, Tom Rix wrote: > Mostly little stuff. > > Consider refactoring create_feature_instance. > > Tom > > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c > > index e220bec..22dc025 100644 > > --- a/drivers/fpga/dfl-pci.c > > +++ b/drivers/fpga/d

Re: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-21 Thread Xu Yilun
On Fri, Jul 17, 2020 at 05:48:55PM +0800, Wu, Hao wrote: > > -Original Message- > > From: linux-fpga-ow...@vger.kernel.org > > On Behalf Of Xu Yilun > > Sent: Wednesday, July 15, 2020 1:38 PM > > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > > ker...@vger.kernel.org > > Cc: t..

RE: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-20 Thread Wu, Hao
> Subject: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own > feature drivers > > This patch makes preparation for modularization of DFL sub feature > drivers. > > Currently, if we need to support a new DFL sub feature, an entry should > be added to fme/port_feature_drvs[] in dfl-fm

Re: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-17 Thread Tom Rix
Mostly little stuff. Consider refactoring create_feature_instance. Tom > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c > index e220bec..22dc025 100644 > --- a/drivers/fpga/dfl-pci.c > +++ b/drivers/fpga/dfl-pci.c > @@ -39,6 +39,11 @@ static void __iomem *cci_pci_ioremap_bar(struct

RE: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-17 Thread Wu, Hao
> -Original Message- > From: linux-fpga-ow...@vger.kernel.org > On Behalf Of Xu Yilun > Sent: Wednesday, July 15, 2020 1:38 PM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; > Wu, Hao ; Matthew Gerl