RE: [PATCH 1/2] pinctrl: tegra: add suspend-resume support

2013-04-28 Thread Bibek Basu
aithatha > Subject: Re: [PATCH 1/2] pinctrl: tegra: add suspend-resume support > > * PGP Signed by an unknown key > > > diff --git a/drivers/pinctrl/pinctrl-tegra.c > > b/drivers/pinctrl/pinctrl-tegra.c > [...] > > @@ -41,6 +42,8 @@ struct tegra_pmx { > > >

RE: [PATCH 1/2] pinctrl: tegra: add suspend-resume support

2013-04-28 Thread Bibek Basu
: [PATCH 1/2] pinctrl: tegra: add suspend-resume support * PGP Signed by an unknown key diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c [...] @@ -41,6 +42,8 @@ struct tegra_pmx { int nbanks; void __iomem **regs; + int *regs_size; Perhaps

Re: [PATCH 1/2] pinctrl: tegra: add suspend-resume support

2013-04-23 Thread Thierry Reding
> diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c [...] > @@ -41,6 +42,8 @@ struct tegra_pmx { > > int nbanks; > void __iomem **regs; > + int *regs_size; Perhaps this should be unsigned int *. The values stored in this array will never be negative,

Re: [PATCH 1/2] pinctrl: tegra: add suspend-resume support

2013-04-23 Thread Thierry Reding
diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c [...] @@ -41,6 +42,8 @@ struct tegra_pmx { int nbanks; void __iomem **regs; + int *regs_size; Perhaps this should be unsigned int *. The values stored in this array will never be negative,