Re: [PATCH 1/2] s2io: add PCI error recovery support

2007-05-21 Thread Linas Vepstas
On Fri, May 18, 2007 at 03:06:53AM -0400, Sivakumar Subramani wrote: > Hi, > > Fix looks good. I have couple of comments, > > 1) Return from s2io_updt_stats function if the PCI bus is offline > (pci_channel_offline). > if (pci_channel_offline(pdev)) > return; OK, missed

RE: [PATCH 1/2] s2io: add PCI error recovery support

2007-05-18 Thread Sivakumar Subramani
Hi, Fix looks good. I have couple of comments, 1) Return from s2io_updt_stats function if the PCI bus is offline (pci_channel_offline). if (pci_channel_offline(pdev)) return; 2) No Need to call netif_wake_queue() in s2io_io_resume as netif_device_attach() will take care

Re: [PATCH 1/2] s2io: add PCI error recovery support

2007-05-14 Thread Linas Vepstas
I failed to cc some of the people on the cc list ... so am resending. --linas On Mon, May 14, 2007 at 06:37:30PM -0500, Linas Vepstas wrote: > > This patch adds PCI error recovery support to the > s2io 10-Gigabit ethernet device driver. Third revision, > blocks interrupts and the watchdog. > >