RE: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-21 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Thursday, September 19, 2019 3:28 AM > > Dexuan Cui writes: > > > BTW, for vss, maybe the VM should not hibernate if there is a backup > > ongoing? -- if the file system is frozen by hv_vss_daemon, and the VM > > hibernates, then when the VM resumes back, it's a

RE: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-19 Thread Vitaly Kuznetsov
Dexuan Cui writes: > BTW, for vss, maybe the VM should not hibernate if there is a backup > ongoing? -- if the file system is frozen by hv_vss_daemon, and the VM > hibernates, then when the VM resumes back, it's almost always true that > the VM won't receive the host's VSS_OP_THAW request, and

RE: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-18 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Monday, September 16, 2019 1:46 AM > Dexuan Cui writes: > > >> From: Vitaly Kuznetsov > >> Sent: Thursday, September 12, 2019 9:37 AM > > > >> > +static int util_suspend(struct hv_device *dev) > >> > +{ > >> > +struct hv_util_service *srv = hv_get_drvdat

RE: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-16 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> From: Vitaly Kuznetsov >> Sent: Thursday, September 12, 2019 9:37 AM > >> > +static int util_suspend(struct hv_device *dev) >> > +{ >> > + struct hv_util_service *srv = hv_get_drvdata(dev); >> > + >> > + if (srv->util_cancel_work) >> > + srv->util_cancel_work();

RE: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-13 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Thursday, September 12, 2019 9:37 AM > > +static int util_suspend(struct hv_device *dev) > > +{ > > + struct hv_util_service *srv = hv_get_drvdata(dev); > > + > > + if (srv->util_cancel_work) > > + srv->util_cancel_work(); > > + > > + vmbus_close(d

Re: [PATCH 1/3] hv_utils: Add the support of hibernation

2019-09-12 Thread Vitaly Kuznetsov
Dexuan Cui writes: > On hibernation, Linux can not guarantee the host side utils operations > still succeed without any issue, so let's simply cancel the work items. > The host is supposed to retry the operations, if necessary. > > Signed-off-by: Dexuan Cui > --- > drivers/hv/hv_fcopy.c |