Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, 25 Jul 2017 13:49:08 +0200 Johan Hovold jo...@kernel.org wrote: >On Wed, Jul 19, 2017 at 01:58:30PM +0200, Anatolij Gustschin wrote: >> On Mon, 10 Jul 2017 14:52:10 +0200 >> Johan Hovold jo...@kernel.org wrote: >> >> >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, 25 Jul 2017 13:49:08 +0200 Johan Hovold jo...@kernel.org wrote: >On Wed, Jul 19, 2017 at 01:58:30PM +0200, Anatolij Gustschin wrote: >> On Mon, 10 Jul 2017 14:52:10 +0200 >> Johan Hovold jo...@kernel.org wrote: >> >> >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, 25 Jul 2017 13:52:35 +0200 Johan Hovold jo...@kernel.org wrote: >On Wed, Jul 19, 2017 at 02:59:00PM +0200, Anatolij Gustschin wrote: >> On Wed, 19 Jul 2017 10:59:34 +0200 >> Johan Hovold jo...@kernel.org wrote: > >> >> And as David Laight already pointed out, your ftdi-fifo-fpp-mgr

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, 25 Jul 2017 13:52:35 +0200 Johan Hovold jo...@kernel.org wrote: >On Wed, Jul 19, 2017 at 02:59:00PM +0200, Anatolij Gustschin wrote: >> On Wed, 19 Jul 2017 10:59:34 +0200 >> Johan Hovold jo...@kernel.org wrote: > >> >> And as David Laight already pointed out, your ftdi-fifo-fpp-mgr

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, Jul 19, 2017 at 02:59:00PM +0200, Anatolij Gustschin wrote: > On Wed, 19 Jul 2017 10:59:34 +0200 > Johan Hovold jo...@kernel.org wrote: > >> And as David Laight already pointed out, your ftdi-fifo-fpp-mgr driver > >> seems too application specific for a generic chip like this. > > > >Of

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, Jul 19, 2017 at 02:59:00PM +0200, Anatolij Gustschin wrote: > On Wed, 19 Jul 2017 10:59:34 +0200 > Johan Hovold jo...@kernel.org wrote: > >> And as David Laight already pointed out, your ftdi-fifo-fpp-mgr driver > >> seems too application specific for a generic chip like this. > > > >Of

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, Jul 19, 2017 at 01:58:30PM +0200, Anatolij Gustschin wrote: > On Mon, 10 Jul 2017 14:52:10 +0200 > Johan Hovold jo...@kernel.org wrote: > > >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > >> Add USB part with common functions for USB-GPIO/I2C/SPI master > >>

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, Jul 19, 2017 at 01:58:30PM +0200, Anatolij Gustschin wrote: > On Mon, 10 Jul 2017 14:52:10 +0200 > Johan Hovold jo...@kernel.org wrote: > > >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > >> Add USB part with common functions for USB-GPIO/I2C/SPI master > >>

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 19 Jul 2017 13:39:36 + David Laight david.lai...@aculab.com wrote: >From: Anatolij Gustschin >> Sent: 19 July 2017 14:30 >... >> >Stupid question, I know, but I cannot help thinking: If you have an >> >EEPROM then why the h... don't you use an application specific device >> >ID?

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 19 Jul 2017 13:39:36 + David Laight david.lai...@aculab.com wrote: >From: Anatolij Gustschin >> Sent: 19 July 2017 14:30 >... >> >Stupid question, I know, but I cannot help thinking: If you have an >> >EEPROM then why the h... don't you use an application specific device >> >ID?

RE: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

From: Anatolij Gustschin > Sent: 19 July 2017 14:30 ... > >Stupid question, I know, but I cannot help thinking: If you have an > >EEPROM then why the h... don't you use an application specific device > >ID? > > It would make sense for adapter devices that you can buy and plug. > In my particular

RE: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

From: Anatolij Gustschin > Sent: 19 July 2017 14:30 ... > >Stupid question, I know, but I cannot help thinking: If you have an > >EEPROM then why the h... don't you use an application specific device > >ID? > > It would make sense for adapter devices that you can buy and plug. > In my particular

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 12 Jul 2017 11:11:46 +0200 Bjørn Mork bj...@mork.no wrote: >Johan Hovold writes: >> On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: >> >>> For devices with connected EEPROM some modes (including UART) are >>> configurable in the EEPROM. For devices

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 12 Jul 2017 11:11:46 +0200 Bjørn Mork bj...@mork.no wrote: >Johan Hovold writes: >> On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: >> >>> For devices with connected EEPROM some modes (including UART) are >>> configurable in the EEPROM. For devices without EEPROM

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 19 Jul 2017 10:59:34 +0200 Johan Hovold jo...@kernel.org wrote: ... >> > +static const struct mfd_cell ftdi_cells[] = { >> > + { .name = "ftdi-cbus-gpio", }, >> > + { .name = "ftdi-mpsse-i2c", }, >> > + { .name = "ftdi-mpsse-spi", }, >> > + { .name = "ftdi-fifo-fpp-mgr", }, >> > +};

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 19 Jul 2017 10:59:34 +0200 Johan Hovold jo...@kernel.org wrote: ... >> > +static const struct mfd_cell ftdi_cells[] = { >> > + { .name = "ftdi-cbus-gpio", }, >> > + { .name = "ftdi-mpsse-i2c", }, >> > + { .name = "ftdi-mpsse-spi", }, >> > + { .name = "ftdi-fifo-fpp-mgr", }, >> > +};

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, 10 Jul 2017 14:52:10 +0200 Johan Hovold jo...@kernel.org wrote: >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: >> Add USB part with common functions for USB-GPIO/I2C/SPI master >> adapters. These allow communication with chip's control, transmit >> and receive

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, 10 Jul 2017 14:52:10 +0200 Johan Hovold jo...@kernel.org wrote: >On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: >> Add USB part with common functions for USB-GPIO/I2C/SPI master >> adapters. These allow communication with chip's control, transmit >> and receive

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, Jul 10, 2017 at 02:52:10PM +0200, Johan Hovold wrote: > On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > > Add USB part with common functions for USB-GPIO/I2C/SPI master > > adapters. These allow communication with chip's control, transmit > > and receive endpoints and

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, Jul 10, 2017 at 02:52:10PM +0200, Johan Hovold wrote: > On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > > Add USB part with common functions for USB-GPIO/I2C/SPI master > > adapters. These allow communication with chip's control, transmit > > and receive endpoints and

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 12 Jul 2017 10:50:03 +0200 Johan Hovold jo...@kernel.org wrote: ... >IIRC we should be able read from the EEPROM, and I would at least expect >there to be a way to retrieve the current mode as well. I've just send a patch for ftdi_sio. Thanks, Anatolij

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Wed, 12 Jul 2017 10:50:03 +0200 Johan Hovold jo...@kernel.org wrote: ... >IIRC we should be able read from the EEPROM, and I would at least expect >there to be a way to retrieve the current mode as well. I've just send a patch for ftdi_sio. Thanks, Anatolij

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

Johan Hovold writes: > On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > >> For devices with connected EEPROM some modes (including UART) are >> configurable in the EEPROM. For devices without EEPROM the default >> mode is always UART, but FIFO-, Bitbang- and

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

Johan Hovold writes: > On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > >> For devices with connected EEPROM some modes (including UART) are >> configurable in the EEPROM. For devices without EEPROM the default >> mode is always UART, but FIFO-, Bitbang- and MPSSE-mode can be

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > On Mon, 10 Jul 2017 14:34:27 +0200 > Johan Hovold jo...@kernel.org wrote: > > >On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: > >> On Fri, 07 Jul 2017 09:48:48 +0200 > >> Bjørn Mork bj...@mork.no wrote: >

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > On Mon, 10 Jul 2017 14:34:27 +0200 > Johan Hovold jo...@kernel.org wrote: > > >On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: > >> On Fri, 07 Jul 2017 09:48:48 +0200 > >> Bjørn Mork bj...@mork.no wrote: >

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, 10 Jul 2017 14:34:27 +0200 Johan Hovold jo...@kernel.org wrote: >On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: >> On Fri, 07 Jul 2017 09:48:48 +0200 >> Bjørn Mork bj...@mork.no wrote: >> >> >[adding Johan on the CC list] >> > >> >Anatolij Gustschin

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Mon, 10 Jul 2017 14:34:27 +0200 Johan Hovold jo...@kernel.org wrote: >On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: >> On Fri, 07 Jul 2017 09:48:48 +0200 >> Bjørn Mork bj...@mork.no wrote: >> >> >[adding Johan on the CC list] >> > >> >Anatolij Gustschin writes: >> >

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > Add USB part with common functions for USB-GPIO/I2C/SPI master > adapters. These allow communication with chip's control, transmit > and receive endpoints and will be used by various FT232H drivers. > +static const struct

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > Add USB part with common functions for USB-GPIO/I2C/SPI master > adapters. These allow communication with chip's control, transmit > and receive endpoints and will be used by various FT232H drivers. > +static const struct

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: > On Fri, 07 Jul 2017 09:48:48 +0200 > Bjørn Mork bj...@mork.no wrote: > > >[adding Johan on the CC list] > > > >Anatolij Gustschin writes: > > > >> +static struct usb_device_id ftdi_mfd_table[] = { > >> + {

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: > On Fri, 07 Jul 2017 09:48:48 +0200 > Bjørn Mork bj...@mork.no wrote: > > >[adding Johan on the CC list] > > > >Anatolij Gustschin writes: > > > >> +static struct usb_device_id ftdi_mfd_table[] = { > >> + { USB_DEVICE(0x0403,

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Fri, 07 Jul 2017 09:48:48 +0200 Bjørn Mork bj...@mork.no wrote: >[adding Johan on the CC list] > >Anatolij Gustschin writes: > >> +static struct usb_device_id ftdi_mfd_table[] = { >> +{ USB_DEVICE(0x0403, 0x6014) }, >> +{} >> +}; >> +MODULE_DEVICE_TABLE(usb,

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

On Fri, 07 Jul 2017 09:48:48 +0200 Bjørn Mork bj...@mork.no wrote: >[adding Johan on the CC list] > >Anatolij Gustschin writes: > >> +static struct usb_device_id ftdi_mfd_table[] = { >> +{ USB_DEVICE(0x0403, 0x6014) }, >> +{} >> +}; >> +MODULE_DEVICE_TABLE(usb, ftdi_mfd_table); > >This

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

[adding Johan on the CC list] Anatolij Gustschin writes: > +static struct usb_device_id ftdi_mfd_table[] = { > + { USB_DEVICE(0x0403, 0x6014) }, > + {} > +}; > +MODULE_DEVICE_TABLE(usb, ftdi_mfd_table); This device ID is currently handled by the ftdi_sio driver, so I

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

[adding Johan on the CC list] Anatolij Gustschin writes: > +static struct usb_device_id ftdi_mfd_table[] = { > + { USB_DEVICE(0x0403, 0x6014) }, > + {} > +}; > +MODULE_DEVICE_TABLE(usb, ftdi_mfd_table); This device ID is currently handled by the ftdi_sio driver, so I believe you at