RE: [PATCH 1/3] tpm: cmd_ready command can be issued only after granting locality

2018-02-01 Thread Winkler, Tomas
> > On Wed, Jan 24, 2018 at 06:33:53PM +, Winkler, Tomas wrote: > > > > - pm_runtime_put(dev); > > > > + pm_runtime_put_sync(dev); > > > > > > Change to put_sync is needed so that the idle handshake gets > completed? > > > > Right. > > Since we seem to agree that your change to g

Re: [PATCH 1/3] tpm: cmd_ready command can be issued only after granting locality

2018-01-29 Thread Jarkko Sakkinen
On Wed, Jan 24, 2018 at 06:33:53PM +, Winkler, Tomas wrote: > > > - pm_runtime_put(dev); > > > + pm_runtime_put_sync(dev); > > > > Change to put_sync is needed so that the idle handshake gets completed? > > Right. Since we seem to agree that your change to get rid of the use of PM runtime sh

RE: [PATCH 1/3] tpm: cmd_ready command can be issued only after granting locality

2018-01-24 Thread Winkler, Tomas
> > The correct sequence is to first request locality and only after that > > perform cmd_ready handshake, otherwise the hardware will drop the > > subsequent message as from the device point of view the cmd_ready > > handshake wasn't performed. Symmetrically locality has to be > > relinquished o

Re: [PATCH 1/3] tpm: cmd_ready command can be issued only after granting locality

2018-01-23 Thread Jarkko Sakkinen
On Tue, Jan 23, 2018 at 01:27:29PM +0200, Tomas Winkler wrote: > The correct sequence is to first request locality and only after > that perform cmd_ready handshake, otherwise the hardware will drop > the subsequent message as from the device point of view the cmd_ready > handshake wasn't performe