RE: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-18 Thread Ryan Lee
ail.com; pe...@perex.cz; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ >comments style > >On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote: >> Mark Brown wrote: >> > On Tue, Jan 09, 2018 at 09:01:58PM -08

RE: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-18 Thread Ryan Lee
gt;Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ >comments style > >On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote: >> Mark Brown wrote: >> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > >> > > @@ -1,4 +1,4 @@

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Mark Brown
On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > > > @@ -1,4 +1,4 @@ > > > -/* SPDX-License-Identifier: GPL-2.0 */ > > > +// SPDX-License-Identifier: GPL-2.0 > > > /* Copyright (c) 2017, Maxim

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Mark Brown
On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > > > @@ -1,4 +1,4 @@ > > > -/* SPDX-License-Identifier: GPL-2.0 */ > > > +// SPDX-License-Identifier: GPL-2.0 > > > /* Copyright (c) 2017, Maxim

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Takashi Iwai
On Wed, 10 Jan 2018 11:15:06 +0100, Mark Brown wrote: > > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0 */ > > +// SPDX-License-Identifier: GPL-2.0 > > /* Copyright (c) 2017, Maxim Integrated */ > > Please change the

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Takashi Iwai
On Wed, 10 Jan 2018 11:15:06 +0100, Mark Brown wrote: > > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0 */ > > +// SPDX-License-Identifier: GPL-2.0 > > /* Copyright (c) 2017, Maxim Integrated */ > > Please change the

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Mark Brown
On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0 > /* Copyright (c) 2017, Maxim Integrated */ Please change the entire header to C++, mixing C and C++ on adjacent lines looks ugly.

Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

2018-01-10 Thread Mark Brown
On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0 > /* Copyright (c) 2017, Maxim Integrated */ Please change the entire header to C++, mixing C and C++ on adjacent lines looks ugly.