Re: [PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-25 Thread Mark Brown
On Thu, Feb 20, 2014 at 06:25:12PM +0100, Jean-Francois Moine wrote: > Some device nodes stay locked and some other ones are not locked > while being used during the card lifetime. Please pay more attention to describing your patches clearly in changelogs and to splitting them up for review. This

Re: [PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-24 Thread Jean-Francois Moine
On Mon, 24 Feb 2014 02:17:00 + "li.xi...@freescale.com" wrote: > > @@ -169,22 +164,26 @@ static int asoc_simple_card_parse_of(struct > > device_node > > *node, > > /* CPU sub-node */ > > ret = -EINVAL; > > np = of_get_child_by_name(node, "simple-audio-card,cpu"); > > - if (np)

RE: [PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-23 Thread li.xi...@freescale.com
> @@ -169,22 +164,26 @@ static int asoc_simple_card_parse_of(struct device_node > *node, > /* CPU sub-node */ > ret = -EINVAL; > np = of_get_child_by_name(node, "simple-audio-card,cpu"); > - if (np) > + if (np) { > ret = asoc_simple_card_sub_parse_of(np, priv