RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-22 Thread Stuart Yoder
:58 PM > > > To: Yoder Stuart-B08248 > > > Cc: Alexander Graf; Rivera Jose-B46482; Phillips Kim-R1AAHA; > > > ; > ; > > > ; Wood Scott-B07421; > > > > > > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex > &g

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-22 Thread
era Jose-B46482; Phillips Kim-R1AAHA; > > ; ; > > ; Wood Scott-B07421; > > > > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex > > APIs > > > > On Fri, 19 Sep 2014 13:25:06 -0500 > > Yoder Stuart-B08248 wrote: >

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-22 Thread Stuart Yoder
> -Original Message- > From: Kim Phillips [mailto:kim.phill...@freescale.com] > Sent: Friday, September 19, 2014 3:58 PM > To: Yoder Stuart-B08248 > Cc: Alexander Graf; Rivera Jose-B46482; Phillips Kim-R1AAHA; > ; ; > ; Wood Scott-B07421; > > Subject:

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-20 Thread Stuart Yoder
> Speaking of which, how does Linux find this new bus? I couldn't find > anything that describes the device tree bindings, but maybe I just > missed them. There is a separate thread on the ARM mailing list with the device tree and binding (device tree will be in arch/arm64): http://www.spinics.ne

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Alexander Graf
On 19.09.14 22:41, Scott Wood wrote: > On Fri, 2014-09-19 at 22:32 +0200, Alexander Graf wrote: >> >> On 19.09.14 22:24, Kim Phillips wrote: >>> On Fri, 19 Sep 2014 14:06:32 -0500 >>> Yoder Stuart-B08248 wrote: >>> >>> +/** >>> + * @briefManagement Complex firmware version in

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Stuart Yoder
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, September 19, 2014 3:33 PM > To: Phillips Kim-R1AAHA; Yoder Stuart-B08248 > Cc: Rivera Jose-B46482; ; ; > ; Wood > Scott-B07421; > Subject: Re: [PATCH 1/4] drivers/bus: Added Free

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Stuart Yoder
> -Original Message- > From: Kim Phillips [mailto:kim.phill...@freescale.com] > Sent: Friday, September 19, 2014 3:25 PM > To: Yoder Stuart-B08248 > Cc: Rivera Jose-B46482; Alexander Graf; ; > ; ker...@vger.kernel.org>; Wood Scott-B07421; > > Subject:

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Kim Phillips
On Fri, 19 Sep 2014 13:25:06 -0500 Yoder Stuart-B08248 wrote: > > From: Yoder Stuart-B08248 > > Sent: Thursday, September 18, 2014 7:19 PM > > > > +/** > > > >>> + * @briefDisconnects one endpoint to remove its network link > > > >>> + * > > > >>> + * @param[in] mc_ioPointer to opa

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Scott Wood
On Fri, 2014-09-19 at 22:32 +0200, Alexander Graf wrote: > > On 19.09.14 22:24, Kim Phillips wrote: > > On Fri, 19 Sep 2014 14:06:32 -0500 > > Yoder Stuart-B08248 wrote: > > > > +/** > > + * @briefManagement Complex firmware version information > > + */ > > +#

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Alexander Graf
On 19.09.14 22:24, Kim Phillips wrote: > On Fri, 19 Sep 2014 14:06:32 -0500 > Yoder Stuart-B08248 wrote: > > +/** > + * @briefManagement Complex firmware version information > + */ > +#define MC_VER_MAJOR 2 > +#define MC_VER_MINOR 0

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Kim Phillips
On Fri, 19 Sep 2014 14:06:32 -0500 Yoder Stuart-B08248 wrote: > > > > +/** > > > > + * @briefManagement Complex firmware version information > > > > + */ > > > > +#define MC_VER_MAJOR 2 > > > > +#define MC_VER_MINOR 0 > > > > > > code should be adjusted to run on

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Stuart Yoder
> > > +/** > > > + * @briefManagement Complex firmware version information > > > + */ > > > +#define MC_VER_MAJOR 2 > > > +#define MC_VER_MINOR 0 > > > > code should be adjusted to run on all *compatible* versions of h/w, > > not strictly the one set in these

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Stuart Yoder
> -Original Message- > From: Yoder Stuart-B08248 > Sent: Thursday, September 18, 2014 7:19 PM > To: 'Alexander Graf'; Rivera Jose-B46482 > Cc: Phillips Kim-R1AAHA; ; ; > ; Wood > Scott-B07421; > Subject: RE: [PATCH 1/4] drivers/bus: Added

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread Kim Phillips
On Thu, 18 Sep 2014 22:05:03 -0500 German Rivera wrote: > On 09/18/2014 03:22 PM, Kim Phillips wrote: > > On Thu, 18 Sep 2014 15:14:03 +0200 > > >>> unnecessarily complicated error path, plus a simpler > implementation can be made if fn can return the mapped address, like > so: >

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread German Rivera
On 09/18/2014 03:22 PM, Kim Phillips wrote: On Thu, 18 Sep 2014 15:14:03 +0200 unnecessarily complicated error path, plus a simpler implementation can be made if fn can return the mapped address, like so: static void __iomem *map_mc_portal(phys_addr_t mc_portal_phys_addr,

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread German Rivera
On 09/18/2014 08:14 AM, Alexander Graf wrote: +int __must_check fsl_create_mc_io(phys_addr_t mc_portal_phys_addr, + uint32_t mc_portal_size, + uint32_t flags, struct fsl_mc_io **new_mc_io) +{ +int error = -EINVAL; +struct fsl_mc_io *mc_io = NULL; +

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Stuart Yoder
im-R1AAHA; Wood Scott-B07421; ag...@suse.de; > linuxppc-rele...@linux.freescale.net > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs > > On Thu, 11 Sep 2014 12:34:21 -0500 > "J. German Rivera" wrote: > > > From: "J. German Rivera&q

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Stuart Yoder
+/** > >>> + * @briefDisconnects one endpoint to remove its network link > >>> + * > >>> + * @param[in] mc_ioPointer to opaque I/O object > >>> + * @param[in]dprc_handleHandle to the DPRC object > >>> + * @param[in] endpointEndpoint configuration parameters. > >>> + * >

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Scott Wood
a...@arndb.de; > > linux-kernel@vger.kernel.org; Yoder Stuart-B08248; Phillips > > Kim-R1AAHA; Wood Scott-B07421; ag...@suse.de; > > linuxppc-rele...@linux.freescale.net > > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex > > APIs > >

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Stuart Yoder
> -Original Message- > From: Kim Phillips [mailto:kim.phill...@freescale.com] > Sent: Thursday, September 18, 2014 3:23 PM > To: Alexander Graf > Cc: Rivera Jose-B46482; ; ; > ; Yoder > Stuart-B08248; Wood Scott-B07421; > Subject: Re: [PATCH 1/4] drivers/bus: Ad

RE: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Stuart Yoder
y, September 18, 2014 3:23 PM > > > To: Alexander Graf > > > Cc: Rivera Jose-B46482; ; ; > > > ; > Yoder > > > Stuart-B08248; Wood Scott-B07421; > > > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex > > > APIs &g

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Scott Wood
t; > ; Yoder > > Stuart-B08248; Wood Scott-B07421; > > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex > > APIs > > > > On Thu, 18 Sep 2014 15:14:03 +0200 > > Alexander Graf wrote: > > > > > > Am 18.09.2014 um 06:17

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Scott Wood
On Thu, 2014-09-18 at 15:22 -0500, Kim Phillips wrote: > On Thu, 18 Sep 2014 15:14:03 +0200 > Alexander Graf wrote: > > > > Am 18.09.2014 um 06:17 schrieb German Rivera > > > : > > > > > >> On 09/15/2014 06:44 PM, Kim Phillips wrote: > > >> On Thu, 11 Sep 2014 12:34:21 -0500 > > >> "J. German R

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Kim Phillips
On Thu, 18 Sep 2014 15:14:03 +0200 Alexander Graf wrote: > > Am 18.09.2014 um 06:17 schrieb German Rivera : > > > >> On 09/15/2014 06:44 PM, Kim Phillips wrote: > >> On Thu, 11 Sep 2014 12:34:21 -0500 > >> "J. German Rivera" wrote: > >> > >>> From: "J. German Rivera" > >>> > >>> APIs to acce

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-18 Thread Alexander Graf
> Am 18.09.2014 um 06:17 schrieb German Rivera : > >> On 09/15/2014 06:44 PM, Kim Phillips wrote: >> On Thu, 11 Sep 2014 12:34:21 -0500 >> "J. German Rivera" wrote: >> >>> From: "J. German Rivera" >>> >>> APIs to access the Management Complex (MC) hardware >>> module of Freescale LS2 SoCs. T

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-17 Thread German Rivera
On 09/15/2014 06:44 PM, Kim Phillips wrote: On Thu, 11 Sep 2014 12:34:21 -0500 "J. German Rivera" wrote: From: "J. German Rivera" APIs to access the Management Complex (MC) hardware module of Freescale LS2 SoCs. This patch includes APIs to check the MC firmware version and to manipulate DPRC

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-17 Thread German Rivera
On 09/11/2014 01:45 PM, Joe Perches wrote: diff --git a/drivers/bus/fsl-mc/dpmng.c b/drivers/bus/fsl-mc/dpmng.c [] +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) +{ + struct mc_command cmd = { 0 }; + int err; + + cmd.header = mc_encode_cmd_hea

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-16 Thread Scott Wood
On Tue, 2014-09-16 at 14:28 -0500, Kim Phillips wrote: > On Mon, 15 Sep 2014 23:31:21 -0500 > Scott Wood wrote: > > > On Mon, 2014-09-15 at 18:44 -0500, Kim Phillips wrote: > > > On Thu, 11 Sep 2014 12:34:21 -0500 > > > "J. German Rivera" wrote: > > > > > > > diff --git a/drivers/bus/fsl-mc/fsl

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-16 Thread Kim Phillips
On Mon, 15 Sep 2014 23:31:21 -0500 Scott Wood wrote: > On Mon, 2014-09-15 at 18:44 -0500, Kim Phillips wrote: > > On Thu, 11 Sep 2014 12:34:21 -0500 > > "J. German Rivera" wrote: > > > > > +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version > > > *mc_ver_info) > > > +{ > > > + struc

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-15 Thread Scott Wood
On Mon, 2014-09-15 at 18:44 -0500, Kim Phillips wrote: > On Thu, 11 Sep 2014 12:34:21 -0500 > "J. German Rivera" wrote: > > > +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) > > +{ > > + struct mc_command cmd = { 0 }; > > we can save some cycles if this initializat

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-15 Thread Kim Phillips
On Thu, 11 Sep 2014 12:34:21 -0500 "J. German Rivera" wrote: > From: "J. German Rivera" > > APIs to access the Management Complex (MC) hardware > module of Freescale LS2 SoCs. This patch includes > APIs to check the MC firmware version and to manipulate > DPRC objects in the MC. > > Signed-off

Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

2014-09-11 Thread Joe Perches
On Thu, 2014-09-11 at 12:34 -0500, J. German Rivera wrote: > APIs to access the Management Complex (MC) hardware > module of Freescale LS2 SoCs. This patch includes > APIs to check the MC firmware version and to manipulate > DPRC objects in the MC. > diff --git a/drivers/bus/fsl-mc/dpmng.c b/drive