RE: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-24 Thread Adam Thomson
On 23 September 2019 23:03, Marco Felsch wrote: > Hi Adam, > > On 19-09-23 16:03, Adam Thomson wrote: > > On 17 September 2019 13:43, Marco Felsch wrote: > > > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > > and is used during suspend_enabe/disable() and during

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-23 Thread Marco Felsch
Hi Adam, On 19-09-23 16:03, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be wrong for both use cases. > >

RE: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-23 Thread Adam Thomson
On 17 September 2019 13:43, Marco Felsch wrote: > Currently the suspend reg_field maps to the pmic voltage selection bits > and is used during suspend_enabe/disable() and during get_mode(). This > seems to be wrong for both use cases. > > Use case one (suspend_enabe/disable): > Those callbacks

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-18 Thread Marco Felsch
Hi Adam, On 19-09-18 12:41, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be wrong for both use cases. >

RE: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-18 Thread Adam Thomson
On 17 September 2019 13:43, Marco Felsch wrote: > Currently the suspend reg_field maps to the pmic voltage selection bits > and is used during suspend_enabe/disable() and during get_mode(). This > seems to be wrong for both use cases. Hi Marco, I'd be very surprised if what was in place was