> From: Josh Triplett
> On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote:
> > OTOH just including extra headers isn't ideal - it can considerably
> > slow down the compilation time. There are many subsystems that don't
> > really separate their internal headers from their external
From: Josh Triplett
On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote:
OTOH just including extra headers isn't ideal - it can considerably
slow down the compilation time. There are many subsystems that don't
really separate their internal headers from their external ones.
On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote:
> > > These warning are non-default GCC warnings. These can be seen either
> > > by adding W=1 while running make (i.e. make W=1) or adding
> > > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
> >
> > By default, we
On Thu, Dec 19, 2013 at 08:58:02AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote:
> > On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
> > wrote:
> > > On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
> > >> Include
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
> because function usb_bus_start_enum() has its prototype declaration in
> include/linux/usb/otg.h.
>
> This eliminates the following warning in core/hcd.c:
>
> > These warning are non-default GCC warnings. These can be seen either
> > by adding W=1 while running make (i.e. make W=1) or adding
> > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
>
> By default, we don't care about 'W=1' warnings, as no one sees them, and
> they don't
On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote:
> On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
> wrote:
> > On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
> >> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
> >> because function
On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
wrote:
> On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
>> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
>> because function usb_bus_start_enum() has its prototype declaration in
>>
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
> because function usb_bus_start_enum() has its prototype declaration in
> include/linux/usb/otg.h.
>
> This eliminates the following warning in core/hcd.c:
>
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
Include appropriate header file include/linux/usb/otg.h in core/hcd.c
because function usb_bus_start_enum() has its prototype declaration in
include/linux/usb/otg.h.
This eliminates the following warning in core/hcd.c:
On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
Include appropriate header file include/linux/usb/otg.h in core/hcd.c
because function usb_bus_start_enum() has its prototype declaration in
On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote:
On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
Include appropriate header file include/linux/usb/otg.h in core/hcd.c
These warning are non-default GCC warnings. These can be seen either
by adding W=1 while running make (i.e. make W=1) or adding
-Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
By default, we don't care about 'W=1' warnings, as no one sees them, and
they don't matter.
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
Include appropriate header file include/linux/usb/otg.h in core/hcd.c
because function usb_bus_start_enum() has its prototype declaration in
include/linux/usb/otg.h.
This eliminates the following warning in core/hcd.c:
On Thu, Dec 19, 2013 at 08:58:02AM -0800, Greg Kroah-Hartman wrote:
On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote:
On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote:
These warning are non-default GCC warnings. These can be seen either
by adding W=1 while running make (i.e. make W=1) or adding
-Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
By default, we don't care
16 matches
Mail list logo