RE: [PATCH 1/8] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-07-01 Thread H Hartley Sweeten
On Monday, July 01, 2013 3:58 AM, Mark Brown wrote: > On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote: >> On 29/06/13 04:42, H Hartley Sweeten wrote: > >>> -static inline u8 >>> -ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg) >>> -{ >>> - return __raw_readb(spi->regs_base +

Re: [PATCH 1/8] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-07-01 Thread Mark Brown
On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote: > On 29/06/13 04:42, H Hartley Sweeten wrote: > > -static inline u8 > > -ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg) > > -{ > > - return __raw_readb(spi->regs_base + reg); > > -} > Is there a particular reason to drop th

Re: [PATCH 1/8] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-06-28 Thread Ryan Mallon
On 29/06/13 04:42, H Hartley Sweeten wrote: > The memory resource used by this driver is ioremap()'d and the normal > read,write calls can be used instead of the __raw_* variants. > > Remove the inline read,write helpers and just do the read,write > directly in the callers. > > Signed-off-by: H