RE: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-01 Thread Ryan Lee
project.org; linux- >ker...@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B >format > >On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote: > >> +if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) || &

RE: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-01 Thread Ryan Lee
rnel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B >format > >On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote: > >> +if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) || >> +(max98927->if

Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-08-29 Thread Mark Brown
On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote: > + if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) || > + (max98927->iface == SND_SOC_DAIFMT_DSP_B)) > + return 0; > + > + /* BCLK configuration */ Why do we not configure the BCLK in DSP modes? That's unusual

Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-08-29 Thread Mark Brown
On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote: > + if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) || > + (max98927->iface == SND_SOC_DAIFMT_DSP_B)) > + return 0; > + > + /* BCLK configuration */ Why do we not configure the BCLK in DSP modes? That's unusual