Re: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-07-25 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> This saves us an atomic operation for each I/O submission and Christoph> completion for the usual case where the driver doesn't set a Christoph> per-target can_queue value. Only a few iscsi hardware Christoph> offload drivers set the per-

Re: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-07-09 Thread Christoph Hellwig
On Wed, Jul 09, 2014 at 01:19:41PM +0200, Hannes Reinecke wrote: >>host_not_ready: >> -atomic_dec(&scsi_target(sdev)->target_busy); >> +if (scsi_target(sdev)->can_queue > 0) >> +atomic_dec(&scsi_target(sdev)->target_busy); >>not_ready: >> /* >> * lock q, handl

Re: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-07-09 Thread Hannes Reinecke
On 06/25/2014 06:51 PM, Christoph Hellwig wrote: This saves us an atomic operation for each I/O submission and completion for the usual case where the driver doesn't set a per-target can_queue value. Only a few iscsi hardware offload drivers set the per-target can_queue value at the moment. Sig

Re: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-06-23 Thread Christoph Hellwig
On Sat, Jun 21, 2014 at 10:10:14PM +, Elliott, Robert (Server Storage) wrote: > > not_ready: > > /* > > * lock q, handle tag, requeue req, and decrement device_busy. We > > There's an extra & in that if statement. Indeed, this crept in during a rebase and a later patch fixes it.

RE: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-06-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 12 June, 2014 8:49 AM > To: James Bottomley > Cc: Jens Axboe; Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH 10/14] scsi: