Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Alexander Duyck
On Tue, Dec 29, 2015 at 11:01 AM, wrote: >>On Mon, Dec 28, 2015 at 9:29 PM, wrote: >>> I had posted a patch recently to enable exposing the VPD-R valyes to sysfs. >>> I need access >>> to these to parse into systemd for network naming (biosdevname style names). >>> >>> >>> The VPD-R is a

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Jordan_Hargrave
>On Mon, Dec 28, 2015 at 9:29 PM, wrote: >> I had posted a patch recently to enable exposing the VPD-R valyes to sysfs. >> I need access >> to these to parse into systemd for network naming (biosdevname style names). >> >> >> The VPD-R is a readonly area contained within the PCI Vital Product

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Alexander Duyck
On Mon, Dec 28, 2015 at 9:29 PM, wrote: >>On 12/18/2015 03:02 PM, Alexander Duyck wrote: >>> On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: On 12/18/2015 02:49 PM, Alexander Duyck wrote: > > On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: >> >> PCI-2.2

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Jordan_Hargrave
>On Mon, Dec 28, 2015 at 9:29 PM, wrote: >> I had posted a patch recently to enable exposing the VPD-R valyes to sysfs. >> I need access >> to these to parse into systemd for network naming (biosdevname style names). >> >> >> The VPD-R is a readonly area contained

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Alexander Duyck
On Mon, Dec 28, 2015 at 9:29 PM, wrote: >>On 12/18/2015 03:02 PM, Alexander Duyck wrote: >>> On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: On 12/18/2015 02:49 PM, Alexander Duyck wrote: > > On Fri, Dec 18, 2015 at 12:35 AM, Hannes

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-29 Thread Alexander Duyck
On Tue, Dec 29, 2015 at 11:01 AM, wrote: >>On Mon, Dec 28, 2015 at 9:29 PM, wrote: >>> I had posted a patch recently to enable exposing the VPD-R valyes to sysfs. >>> I need access >>> to these to parse into systemd for network naming

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-28 Thread Jordan_Hargrave
>On 12/18/2015 03:02 PM, Alexander Duyck wrote: >> On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: >>> On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: > > PCI-2.2 VPD entries have a maximum size of 32k, but might

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-28 Thread Jordan_Hargrave
>On 12/18/2015 03:02 PM, Alexander Duyck wrote: >> On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: >>> On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: > > PCI-2.2 VPD entries have a

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Hannes Reinecke
On 12/18/2015 03:02 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but might actually be smaller than

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: > On 12/18/2015 02:49 PM, Alexander Duyck wrote: >> >> On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: >>> >>> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >>> be smaller than that. To figure out the actual

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Hannes Reinecke
On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but might actually be smaller than that. To figure out the actual size one has to read the VPD area until the 'end marker' is reached. Trying

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: > PCI-2.2 VPD entries have a maximum size of 32k, but might actually > be smaller than that. To figure out the actual size one has to read > the VPD area until the 'end marker' is reached. > Trying to read VPD data beyond that marker

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Hannes Reinecke
On 12/18/2015 03:02 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Hannes Reinecke
On 12/18/2015 02:49 PM, Alexander Duyck wrote: On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but might actually be smaller than that. To figure out the actual size one has to read the VPD area until the 'end marker' is

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: > PCI-2.2 VPD entries have a maximum size of 32k, but might actually > be smaller than that. To figure out the actual size one has to read > the VPD area until the 'end marker' is reached. > Trying to read VPD data beyond that

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote: > On 12/18/2015 02:49 PM, Alexander Duyck wrote: >> >> On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote: >>> >>> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >>> be smaller than that.

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Hannes Reinecke
On 12/17/2015 06:13 PM, Alexander Duyck wrote: On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but might actually be smaller than that. To figure out the actual size one has to read the VPD area until the 'end marker' is reached. Trying

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Alexander Duyck
On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote: > PCI-2.2 VPD entries have a maximum size of 32k, but might actually > be smaller than that. To figure out the actual size one has to read > the VPD area until the 'end marker' is reached. > Trying to read VPD data beyond that marker

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread kbuild test robot
Hi Hannes, [auto build test WARNING on pci/next] [also build test WARNING on v4.4-rc5 next-20151217] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/pci-Update-VPD-definitions/20151217-160050 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Seymour, Shane M
Tested with a HP AE311-60001 PCIe card. It used to repeat the same VPD every 4k for 32k now only the 154 bytes are returned and lspci - reports that the data up to and including the end and that the check sum is good: ... Capabilities: [74] Vital Product Data Product

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Alexander Duyck
On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote: > PCI-2.2 VPD entries have a maximum size of 32k, but might actually > be smaller than that. To figure out the actual size one has to read > the VPD area until the 'end marker' is reached. > Trying to read VPD data beyond that

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Hannes Reinecke
On 12/17/2015 06:13 PM, Alexander Duyck wrote: On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote: PCI-2.2 VPD entries have a maximum size of 32k, but might actually be smaller than that. To figure out the actual size one has to read the VPD area until the 'end marker' is

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Seymour, Shane M
Tested with a HP AE311-60001 PCIe card. It used to repeat the same VPD every 4k for 32k now only the 154 bytes are returned and lspci - reports that the data up to and including the end and that the check sum is good: ... Capabilities: [74] Vital Product Data Product

Re: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread kbuild test robot
Hi Hannes, [auto build test WARNING on pci/next] [also build test WARNING on v4.4-rc5 next-20151217] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/pci-Update-VPD-definitions/20151217-160050 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next