Re: [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0]

2019-02-26 Thread Dennis Zhou
On Tue, Feb 26, 2019 at 03:15:50PM +, Christopher Lameter wrote: > On Mon, 25 Feb 2019, den...@kernel.org wrote: > > > > @@ -67,7 +67,7 @@ static struct pcpu_chunk *pcpu_create_chunk(gfp_t gfp) > > > pcpu_set_page_chunk(nth_page(pages, i), chunk); > > > > > > chunk->data = pages; >

Re: [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0]

2019-02-26 Thread Christopher Lameter
On Mon, 25 Feb 2019, den...@kernel.org wrote: > > @@ -67,7 +67,7 @@ static struct pcpu_chunk *pcpu_create_chunk(gfp_t gfp) > > pcpu_set_page_chunk(nth_page(pages, i), chunk); > > > > chunk->data = pages; > > - chunk->base_addr = page_address(pages) - pcpu_group_offsets[0]; > > +

RE: [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0]

2019-02-25 Thread Peng Fan
Hi Dennis, > -Original Message- > From: den...@kernel.org [mailto:den...@kernel.org] > Sent: 2019年2月25日 23:16 > To: Peng Fan > Cc: t...@kernel.org; c...@linux.com; linux...@kvack.org; > linux-kernel@vger.kernel.org; van.free...@gmail.com > Subject: Re: [PATCH 2/2] p

Re: [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0]

2019-02-25 Thread den...@kernel.org
On Sun, Feb 24, 2019 at 01:13:50PM +, Peng Fan wrote: > percpu-km is used on UP systems which only has one group, > so the group offset will be always 0, there is no need > to subtract pcpu_group_offsets[0] when assigning chunk->base_addr > > Signed-off-by: Peng Fan > --- > mm/percpu-km.c |