Re: [PATCH 2/2] x86: fix __user annotations

2019-04-01 Thread Jann Horn
On Mon, Apr 1, 2019 at 4:36 PM David Laight wrote: > > From: Jann Horn > > Sent: 28 March 2019 21:23 > > Fix __user annotations in various places across the x86 tree: > > > ... > > - generic_load_microcode() deals with a pointer that can be either a > >kernel pointer or a user pointer; change

RE: [PATCH 2/2] x86: fix __user annotations

2019-04-01 Thread David Laight
From: Jann Horn > Sent: 28 March 2019 21:23 > Fix __user annotations in various places across the x86 tree: > ... > - generic_load_microcode() deals with a pointer that can be either a >kernel pointer or a user pointer; change the code to pass it around as >a __user pointer, and add expli

Re: [PATCH 2/2] x86: fix __user annotations

2019-03-29 Thread Jann Horn
On Fri, Mar 29, 2019 at 2:39 PM Borislav Petkov wrote: > > On Thu, Mar 28, 2019 at 10:23:21PM +0100, Jann Horn wrote: > > Fix __user annotations in various places across the x86 tree: > > > > - cast to wrong pointer type in __user_atomic_cmpxchg_inatomic() > > - generic_load_microcode() deals wi

Re: [PATCH 2/2] x86: fix __user annotations

2019-03-29 Thread Ben Dooks
On 2019-03-29 13:39, Borislav Petkov wrote: On Thu, Mar 28, 2019 at 10:23:21PM +0100, Jann Horn wrote: Fix __user annotations in various places across the x86 tree: - cast to wrong pointer type in __user_atomic_cmpxchg_inatomic() - generic_load_microcode() deals with a pointer that can be

Re: [PATCH 2/2] x86: fix __user annotations

2019-03-29 Thread Borislav Petkov
On Thu, Mar 28, 2019 at 10:23:21PM +0100, Jann Horn wrote: > Fix __user annotations in various places across the x86 tree: > > - cast to wrong pointer type in __user_atomic_cmpxchg_inatomic() > - generic_load_microcode() deals with a pointer that can be either a >kernel pointer or a user poi