Thank you for continuing the discussion.
The reply was delayed to summarize the arguing points.
> I already gave my comment on previous thread, and I prefer de array handling
> I sent instead of only two entries.
We haven't discussed enough yet and I have some questions.
I still don't understand
BTW
Are you busy now?
I'm sorry, I'm so busy for my full time work :( Anyway, I'm trying to review
serious bug patches or
bug reports first.
Other patches, such as clean-up or code refactoring, may take some time to
review.
I am waiting for your reply about "integrates dir-entry getting an
Are you busy now?
I'm sorry, I'm so busy for my full time work :(
Anyway, I'm trying to review serious bug patches or bug reports first.
Other patches, such as clean-up or code refactoring, may take some time to
review.
I'll try to reduce your burden as much as possible.
I am waiting for you
It might check if the cluster numbers are same between source entry
and target directory.
This checks if newdir is the move target itself.
Example:
mv /mnt/dir0 /mnt/dir0/foo
However, this check is not enough.
We need to check newdir and all ancestors.
Example:
mv /mnt/dir0 /mnt/dir0/di
> > >> --- a/fs/exfat/namei.c
> > >> +++ b/fs/exfat/namei.c
> > >> @@ -1095,11 +1095,6 @@ static int exfat_move_file(struct inode
> > >> *inode, struct exfat_chain *p_olddir,
> > >> if (!epmov)
> > >> return -EIO;
> > >>
> > >> -/* check if the source and target di
> >> --- a/fs/exfat/namei.c
> >> +++ b/fs/exfat/namei.c
> >> @@ -1095,11 +1095,6 @@ static int exfat_move_file(struct inode
> >> *inode, struct exfat_chain *p_olddir,
> >>if (!epmov)
> >>return -EIO;
> >>
> >> - /* check if the source and target directory is the same */
> >> - if
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -1095,11 +1095,6 @@ static int exfat_move_file(struct inode *inode,
struct exfat_chain *p_olddir,
if (!epmov)
return -EIO;
- /* check if the source and target directory is the same */
- if (exfat_get_entry_type(e
> In exfat_move_file(), the identity of source and target directory has been
> checked by the caller.
> Also, it gets stream.start_clu from file dir-entry, which is an invalid
> determination.
>
> Signed-off-by: Tetsuhiro Kohada
> ---
> fs/exfat/namei.c | 5 -
> 1 file changed, 5 deletions(-
8 matches
Mail list logo
