RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> > On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > > > > +++ b/mmc_cmds.c > > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > > } > > > > > > if (ext_csd_rev >= 7) { > > > - printf("eMMC Firmware Version: %s\n", > > > -

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> > On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > > > > +++ b/mmc_cmds.c > > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > > } > > > > > > if (ext_csd_rev >= 7) { > > > - printf("eMMC Firmware Version: %s\n", > > > -

Re: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread James Nuss
On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > +++ b/mmc_cmds.c > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > } > > > > if (ext_csd_rev >= 7) { > > - printf("eMMC Firmware Version: %s\n", > > -

Re: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread James Nuss
On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > +++ b/mmc_cmds.c > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > } > > > > if (ext_csd_rev >= 7) { > > - printf("eMMC Firmware Version: %s\n", > > -

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> +++ b/mmc_cmds.c > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - printf("eMMC Firmware Version: %s\n", > - (char*)_csd[EXT_CSD_FIRMWARE_VERSION]); > + printf("Firmware Version: >

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> +++ b/mmc_cmds.c > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - printf("eMMC Firmware Version: %s\n", > - (char*)_csd[EXT_CSD_FIRMWARE_VERSION]); > + printf("Firmware Version: >