Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Lee Jones
On Thu, 05 Nov 2020, Paul Fulghum wrote: > > Another candidate for removal is drivers/char/pcmcia/synclink_cs.c > > Everything I said about synclink.c/synclinkmp.c is true of that as well: the > hardware stopped being manufactured decades ago and is not available for > testing. The possibility

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Paul Fulghum
Another candidate for removal is drivers/char/pcmcia/synclink_cs.c Everything I said about synclink.c/synclinkmp.c is true of that as well: the hardware stopped being manufactured decades ago and is not available for testing. The possibility of these cards still being around/functional for use

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Jiri Slaby
On 05. 11. 20, 12:04, David Laight wrote: And the loop can be turned into ndelay: /* * Force at least 170ns delay before clearing * reset bit. Each read from LCR takes at least * 30ns so 10 times for 300ns to be safe. */ for(i=0;i<1

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Lee Jones
On Thu, 05 Nov 2020, David Laight wrote: > > >> And the loop can be turned into ndelay: > > >> > > >> /* > > >> * Force at least 170ns delay before clearing > > >> * reset bit. Each read from LCR takes at least > > >> * 30ns so 10 times for 300ns to be safe.

RE: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread David Laight
> >> And the loop can be turned into ndelay: > >> > >> /* > >> * Force at least 170ns delay before clearing > >> * reset bit. Each read from LCR takes at least > >> * 30ns so 10 times for 300ns to be safe. > >> */ > >> for(i=0;i<10;i++) > >>

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Jiri Slaby
On 05. 11. 20, 10:39, Paul Fulghum wrote: If there are no objections to removing the the old drivers (synclink.c/synclink_mp.c) I could make a patch to do so tomorrow (it is 1:30am here now). Nothing eliminates niggling warnings like removing dead code. \o/ Thanks a lot. -- js suse labs

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Lee Jones
On Thu, 05 Nov 2020, Greg Kroah-Hartman wrote: > On Thu, Nov 05, 2020 at 01:39:36AM -0800, Paul Fulghum wrote: > > > > > > > On Nov 5, 2020, at 1:10 AM, Jiri Slaby wrote: > > > > > > OK, let the loop alone. I would bet a half a pig that noone is able to > > > test this driver. But one has to

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 05, 2020 at 01:39:36AM -0800, Paul Fulghum wrote: > > > > On Nov 5, 2020, at 1:10 AM, Jiri Slaby wrote: > > > > OK, let the loop alone. I would bet a half a pig that noone is able to test > > this driver. But one has to write this for someone to raise and admit they > > are still

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Paul Fulghum
> On Nov 5, 2020, at 1:10 AM, Jiri Slaby wrote: > > OK, let the loop alone. I would bet a half a pig that noone is able to test > this driver. But one has to write this for someone to raise and admit they > are still using it. In fact, there are _4_ google replies to "Microgate > Corporatio

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Jiri Slaby
On 05. 11. 20, 9:43, Lee Jones wrote: On Thu, 05 Nov 2020, Jiri Slaby wrote: On 04. 11. 20, 20:35, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/tty/synclinkmp.c: In function ‘init_adapter’: drivers/tty/synclinkmp.c:5167:6: warning: variable ‘readval’ set but

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Lee Jones
On Thu, 05 Nov 2020, Jiri Slaby wrote: > On 04. 11. 20, 20:35, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/tty/synclinkmp.c: In function ‘init_adapter’: > > drivers/tty/synclinkmp.c:5167:6: warning: variable ‘readval’ set but not > > used [-Wunused-b

Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always_unused

2020-11-05 Thread Jiri Slaby
On 04. 11. 20, 20:35, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/tty/synclinkmp.c: In function ‘init_adapter’: drivers/tty/synclinkmp.c:5167:6: warning: variable ‘readval’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc