ummaluri <rgum...@xilinx.com>
> Subject: Re: [PATCH 3/3] PCI: Xilinx NWL PCIe: Fix Error for multi function
> device
> for legacy interrupts.
>
> On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> > On 12/09/16 23:02, Bjorn Helgaas wrote:
> > > On
oogle.com; colin.k...@canonical.com; Soren Brinkmann
> ; Michal Simek ; a...@arndb.de;
> linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Ravikiran Gummaluri
> Subject: Re: [PATCH 3/3] PCI: Xilinx NWL PCIe: Fix Error for multi function
&g
Hi,
On Tuesday 13 September 2016 09:04 PM, Bjorn Helgaas wrote:
> [+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
>
> On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
>> On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
>>> On 12/09/16
Hi,
On Tuesday 13 September 2016 09:04 PM, Bjorn Helgaas wrote:
> [+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
>
> On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
>> On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
>>> On 12/09/16
> [+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
>
> On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
> > On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> > > On 12/09/16 23:02, Bjorn Helgaas wrote:
> > > > On Thu, Sep 01, 2016 at
> [+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
>
> On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
> > On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> > > On 12/09/16 23:02, Bjorn Helgaas wrote:
> > > > On Thu, Sep 01, 2016 at
Hello,
On Tue, 13 Sep 2016 10:34:02 -0500, Bjorn Helgaas wrote:
> > After looking at this myself, I'm not happy with this either. It feels
> > like there are bugs lurking here and we're just hiding one of them.
> >
> > Here are the callers of irq_domain_add_linear() for legacy INTx in
> >
Hello,
On Tue, 13 Sep 2016 10:34:02 -0500, Bjorn Helgaas wrote:
> > After looking at this myself, I'm not happy with this either. It feels
> > like there are bugs lurking here and we're just hiding one of them.
> >
> > Here are the callers of irq_domain_add_linear() for legacy INTx in
> >
[+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> > On 12/09/16 23:02, Bjorn Helgaas wrote:
> > > On Thu, Sep 01, 2016 at 05:19:55AM +,
[+cc Ley Foon (altera), Thomas (aardvark), Kishon (dra7xx), Murali (keystone)]
On Tue, Sep 13, 2016 at 10:05:11AM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> > On 12/09/16 23:02, Bjorn Helgaas wrote:
> > > On Thu, Sep 01, 2016 at 05:19:55AM +,
On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> On 12/09/16 23:02, Bjorn Helgaas wrote:
> > On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
> >>> Hi Bharat,
> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> nwl_pcie
>
On Tue, Sep 13, 2016 at 08:41:28AM +0100, Marc Zyngier wrote:
> On 12/09/16 23:02, Bjorn Helgaas wrote:
> > On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
> >>> Hi Bharat,
> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> nwl_pcie
>
On 12/09/16 23:02, Bjorn Helgaas wrote:
> On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
>>> Hi Bharat,
@@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
nwl_pcie
>>> *pcie)
}
pcie->legacy_irq_domain =
On 12/09/16 23:02, Bjorn Helgaas wrote:
> On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
>>> Hi Bharat,
@@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
nwl_pcie
>>> *pcie)
}
pcie->legacy_irq_domain =
On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
> > Hi Bharat,
> > > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> > > nwl_pcie
> > *pcie)
> > > }
> > >
> > > pcie->legacy_irq_domain =
On Thu, Sep 01, 2016 at 05:19:55AM +, Bharat Kumar Gogada wrote:
> > Hi Bharat,
> > > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> > > nwl_pcie
> > *pcie)
> > > }
> > >
> > > pcie->legacy_irq_domain =
> Hi Bharat,
> > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> > nwl_pcie
> *pcie)
> > }
> >
> > pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> > - INTX_NUM,
> >
> Hi Bharat,
> > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> > nwl_pcie
> *pcie)
> > }
> >
> > pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> > - INTX_NUM,
> >
On 31/08/16 10:56, Bharat Kumar Gogada wrote:
> > On 30/08/16 15:13, Bharat Kumar Gogada wrote:
Hi Bharat,
> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> nwl_pcie
*pcie)
> }
>
> pcie->legacy_irq_domain =
On 31/08/16 10:56, Bharat Kumar Gogada wrote:
> > On 30/08/16 15:13, Bharat Kumar Gogada wrote:
Hi Bharat,
> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> nwl_pcie
*pcie)
> }
>
> pcie->legacy_irq_domain =
> On 30/08/16 15:13, Bharat Kumar Gogada wrote:
> >> Hi Bharat,
> >>> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> >>> nwl_pcie
> >> *pcie)
> >>> }
> >>>
> >>> pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> >>> -
> On 30/08/16 15:13, Bharat Kumar Gogada wrote:
> >> Hi Bharat,
> >>> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct
> >>> nwl_pcie
> >> *pcie)
> >>> }
> >>>
> >>> pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> >>> -
On 30/08/16 15:13, Bharat Kumar Gogada wrote:
>> Hi Bharat,
>>> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie
>> *pcie)
>>> }
>>>
>>> pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
>>> -
On 30/08/16 15:13, Bharat Kumar Gogada wrote:
>> Hi Bharat,
>>> @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie
>> *pcie)
>>> }
>>>
>>> pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
>>> -
> Hi Bharat,
> > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie
> *pcie)
> > }
> >
> > pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> > - INTX_NUM,
> > +
> Hi Bharat,
> > @@ -561,7 +561,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie
> *pcie)
> > }
> >
> > pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
> > - INTX_NUM,
> > +
Hi Bharat,
On 30/08/16 11:39, Bharat Kumar Gogada wrote:
> PCIe legacy interrupts start at 1, not at 0.
> When testing with multi function device "error: hwirq 0x4 is too large for
> dummy" error comes.
> So adding one addtional interrupt when creating irq domain.
>
> Signed-off-by: Bharat Kumar
Hi Bharat,
On 30/08/16 11:39, Bharat Kumar Gogada wrote:
> PCIe legacy interrupts start at 1, not at 0.
> When testing with multi function device "error: hwirq 0x4 is too large for
> dummy" error comes.
> So adding one addtional interrupt when creating irq domain.
>
> Signed-off-by: Bharat Kumar
28 matches
Mail list logo
