Re: [PATCH 3/3] backlight: lp855x: remove goto err_dev

2012-08-07 Thread Jingoo Han
On Tuesday, August 07, 2012 5:32 PM Kim, Milo wrote: > > > This patch removes goto err_dev, which makes code a bit smaller. > > Thanks ! > IMO, goto statements are meaningful on _probe(). > However, 'goto err_sysfs' also can be removed if the size of code is critical. OK, I will send v2 patch.

RE: [PATCH 3/3] backlight: lp855x: remove goto err_dev

2012-08-07 Thread Kim, Milo
> This patch removes goto err_dev, which makes code a bit smaller. Thanks ! IMO, goto statements are meaningful on _probe(). However, 'goto err_sysfs' also can be removed if the size of code is critical. drivers/video/backlight/lp855x_bl.c | 12 1 files changed, 4 insertions(+), 8