RE: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-11-16 Thread 冯锐
ubject: Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261 > > On Fri, Oct 23, 2020 at 02:12:19PM +0200, Ulf Hansson wrote: > > SD spec mentions the write-protect switch on SD cards, while uSD cards > > doesn't have one. In general, host drivers implement supp

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-11-12 Thread Christoph Hellwig
On Fri, Oct 23, 2020 at 02:12:19PM +0200, Ulf Hansson wrote: > SD spec mentions the write-protect switch on SD cards, while uSD cards > doesn't have one. In general, host drivers implement support for it > via a dedicated GPIO line routed to one of the pins in the SD slot. > > In this SD controlle

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-28 Thread Ulf Hansson
On Wed, 28 Oct 2020 at 11:05, 冯锐 wrote: > > > > > > > > > On Mon, 26 Oct 2020 at 09:22, 冯锐 wrote: > > > > > > > > > > > > > > + Christoph (to help us understand if PCIe/NVMe devices can be > > > > > + marked > > > > > + read-only) > > > > > > > > > > On Thu, 22 Oct 2020 at 08:04, 冯锐 wrote: > > >

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-27 Thread Christoph Hellwig
On Tue, Oct 27, 2020 at 01:54:46PM +0100, Ulf Hansson wrote: > > For information security purpose, some companies or business users set > > their notebook SD as "read only". > > Because a lot of "read only" requirements from those companies or business > > users, notebook vendor controls reader w

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-27 Thread Ulf Hansson
On Mon, 26 Oct 2020 at 09:22, 冯锐 wrote: > > > > > + Christoph (to help us understand if PCIe/NVMe devices can be marked > > + read-only) > > > > On Thu, 22 Oct 2020 at 08:04, 冯锐 wrote: > > > > > > > > > > > On Fri, 25 Sep 2020 at 03:57, wrote: > > > > > > > > > > From: Rui Feng > > > > > > > >

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-23 Thread Christoph Hellwig
On Fri, Oct 23, 2020 at 02:12:19PM +0200, Ulf Hansson wrote: > If I understand you correctly, you are saying that the controller > should be able to communicate (upwards to the block layer) its known > write protect state for the corresponding NVMe device, during > initialization? Yes.

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-23 Thread Ulf Hansson
On Fri, 23 Oct 2020 at 11:14, Christoph Hellwig wrote: > > On Fri, Oct 23, 2020 at 10:02:15AM +0200, Ulf Hansson wrote: > > > > Is there no mechanism to support read-only PCIe/NVMe based storage > > > > devices? > > > > If that is the case, maybe it's simply better to not support the > > > > rea

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-23 Thread Christoph Hellwig
On Fri, Oct 23, 2020 at 10:02:15AM +0200, Ulf Hansson wrote: > > > Is there no mechanism to support read-only PCIe/NVMe based storage > > > devices? > > > If that is the case, maybe it's simply better to not support the readonly > > > option > > > at all for SD express cards? > > > > > I think th

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-23 Thread Ulf Hansson
+ Christoph (to help us understand if PCIe/NVMe devices can be marked read-only) On Thu, 22 Oct 2020 at 08:04, 冯锐 wrote: > > > > > On Fri, 25 Sep 2020 at 03:57, wrote: > > > > > > From: Rui Feng > > > > > > RTS5261 support legacy SD mode and SD Express mode. > > > In SD7.x, SD association intro

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-21 Thread Ulf Hansson
On Fri, 25 Sep 2020 at 03:57, wrote: > > From: Rui Feng > > RTS5261 support legacy SD mode and SD Express mode. > In SD7.x, SD association introduce SD Express as a new mode. > This patch makes RTS5261 support SD Express mode. As per patch 2, can you please add some more information about what c

Re: [PATCH 3/3] mmc: rtsx: Add SD Express mode support for RTS5261

2020-10-20 Thread Ulf Hansson
On Tue, 20 Oct 2020 at 08:52, 冯锐 wrote: > > Hi All, > > A month has passed, do I need to modify these patches? Unfortunately I didn't get the time to review them before the merge window opened, but I am looking at them now. Allow me a day or two to complete the review. Kind regards Ufffe > > Th