RE: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-11 Thread David Laight
From: Masami Hiramatsu > Sent: 11 May 2020 10:28 ... > > We may not avoid fixing related failures after your change: > > 1) We have to reuse built-in echo (do alias echo=echo) if we want to > > test common_pid for histogram. > > 2) We have to reuse built-in echo if some new tests want to interpret

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-11 Thread Masami Hiramatsu
On Mon, 11 May 2020 15:22:25 +0800 Xiao Yang wrote: > On 2020/5/7 17:15, Masami Hiramatsu wrote: > > On Thu, 7 May 2020 14:45:16 +0800 > > Xiao Yang wrote: > > > >> On 2020/5/1 21:38, Masami Hiramatsu wrote: > >>> Since the built-in echo has different behavior in POSIX shell > >>> (dash) and bas

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-11 Thread Xiao Yang
On 2020/5/7 17:15, Masami Hiramatsu wrote: On Thu, 7 May 2020 14:45:16 +0800 Xiao Yang wrote: On 2020/5/1 21:38, Masami Hiramatsu wrote: Since the built-in echo has different behavior in POSIX shell (dash) and bash, we forcibly use /bin/echo -E (not interpret backslash escapes) by default. T

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-08 Thread Masami Hiramatsu
On Thu, 7 May 2020 15:32:46 -0500 "Zanussi, Tom" wrote: > Hi, > > On 5/7/2020 12:25 PM, Steven Rostedt wrote: > > On Fri, 8 May 2020 00:50:28 +0900 > > Masami Hiramatsu wrote: > > > Yes, I need Tom's review for this change. As far as I can test, this > fixes the test failure. If this

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Zanussi, Tom
Hi, On 5/7/2020 12:25 PM, Steven Rostedt wrote: On Fri, 8 May 2020 00:50:28 +0900 Masami Hiramatsu wrote: Yes, I need Tom's review for this change. As far as I can test, this fixes the test failure. If this isn't acceptable, we can use "alias echo=echo" for this test case. I still don't

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Steven Rostedt
On Fri, 8 May 2020 00:50:28 +0900 Masami Hiramatsu wrote: > > > Yes, I need Tom's review for this change. As far as I can test, this > > > fixes the test failure. If this isn't acceptable, we can use "alias > > > echo=echo" > > > for this test case. > > > > > > > I still don't see how changi

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Masami Hiramatsu
On Thu, 07 May 2020 11:22:28 +0200 Andreas Schwab wrote: > On Mai 01 2020, Masami Hiramatsu wrote: > > > Since the built-in echo has different behavior in POSIX shell > > (dash) and bash, we forcibly use /bin/echo -E (not interpret > > backslash escapes) by default. > > How about using printf i

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Masami Hiramatsu
On Thu, 7 May 2020 09:12:07 -0400 Steven Rostedt wrote: > On Sat, 2 May 2020 12:08:42 +0900 > Masami Hiramatsu wrote: > > > > > diff --git > > > > a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-hist.tc > > > > > > > > b/tools/testing/selftests/ftrace/test.d/trigger/trig

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Steven Rostedt
On Sat, 2 May 2020 12:08:42 +0900 Masami Hiramatsu wrote: > > > diff --git > > > a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-hist.tc > > > > > > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-hist.tc > > > index ab6bedb25736..b3f70f53ee69 100644 >

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Andreas Schwab
On Mai 01 2020, Masami Hiramatsu wrote: > Since the built-in echo has different behavior in POSIX shell > (dash) and bash, we forcibly use /bin/echo -E (not interpret > backslash escapes) by default. How about using printf instead (at least where it matters)? Andreas. -- Andreas Schwab, sch...

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Masami Hiramatsu
On Thu, 7 May 2020 14:45:16 +0800 Xiao Yang wrote: > On 2020/5/1 21:38, Masami Hiramatsu wrote: > > Since the built-in echo has different behavior in POSIX shell > > (dash) and bash, we forcibly use /bin/echo -E (not interpret > > backslash escapes) by default. > > > > This also fixes some test c

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-06 Thread Xiao Yang
On 2020/5/1 21:38, Masami Hiramatsu wrote: Since the built-in echo has different behavior in POSIX shell (dash) and bash, we forcibly use /bin/echo -E (not interpret backslash escapes) by default. This also fixes some test cases which expects built-in echo command. Reported-by: Liu Yiding Signe

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-01 Thread Masami Hiramatsu
On Fri, 1 May 2020 10:19:42 -0400 Steven Rostedt wrote: > On Fri, 1 May 2020 22:38:00 +0900 > Masami Hiramatsu wrote: > > > Since the built-in echo has different behavior in POSIX shell > > (dash) and bash, we forcibly use /bin/echo -E (not interpret > > backslash escapes) by default. > > > >

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-01 Thread Steven Rostedt
On Fri, 1 May 2020 22:38:00 +0900 Masami Hiramatsu wrote: > Since the built-in echo has different behavior in POSIX shell > (dash) and bash, we forcibly use /bin/echo -E (not interpret > backslash escapes) by default. > > This also fixes some test cases which expects built-in > echo command. >