Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

2014-08-29 Thread Lee Jones
On Tue, 19 Aug 2014, Wei-Chun Pan wrote: > > You've replied to this email as an independent message, so now there is > > little > > context. When you reply, please ensure your mailer replies to the thread. > > > > Could you tell me more detail about this? > I use Git to reply mails but don't k

Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

2014-08-19 Thread Wei-Chun Pan
> You've replied to this email as an independent message, so now there is little > context. When you reply, please ensure your mailer replies to the thread. > Could you tell me more detail about this? I use Git to reply mails but don't know how to set them to be dependent on. > On Thu, 07 Aug 2

Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

2014-08-07 Thread Lee Jones
You've replied to this email as an independent message, so now there is little context. When you reply, please ensure your mailer replies to the thread. On Thu, 07 Aug 2014, Wei-Chun Pan wrote: > I have a question for your comment. As your mail, > > > > + > > > +static void __exit imanager2_mfd_

RE: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

2014-08-07 Thread Wei-Chun Pan
I have a question for your comment. As your mail, > > + > > +static void __exit imanager2_mfd_device_exit(void) { > > + mfd_remove_devices(&ec_pdev->dev); > > + platform_device_unregister(ec_pdev); > > +} > > + > > +module_init(imanager2_mfd_device_init); > > +module_exit(imanager2_mfd_device_

Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

2014-07-22 Thread Lee Jones
There is no way that you are introducing a 300 line driver and have nothing to say about it. Please put a nice descriptive commit log here when you resubmit. > Signed-off-by: Wei-Chun Pan > --- I also expect to see a change log here and version information in the $SUBJECT line of the email. I