RE: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-09 Thread Yu, Fenghua
> From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Thursday, August 08, 2013 11:29 AM > On Thu, Aug 08, 2013 at 12:02:38PM +0200, Borislav Petkov wrote: > > On Wed, Aug 07, 2013 at 07:22:39PM -0700, H. Peter Anvin wrote: > > > How much does this matter? > > > > I know what you're asking :-) >

RE: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-09 Thread Yu, Fenghua
> From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Thursday, August 08, 2013 10:49 AM > On Wed, Aug 07, 2013 at 11:34:01PM +, Yu, Fenghua wrote: > > > This check won't work when CPU0 is hot added. So we need to find a > > > better way to fix this. > > > > > > > Maybe need to change the che

Re: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-08 Thread Borislav Petkov
On Thu, Aug 08, 2013 at 12:02:38PM +0200, Borislav Petkov wrote: > On Wed, Aug 07, 2013 at 07:22:39PM -0700, H. Peter Anvin wrote: > > How much does this matter? > > I know what you're asking :-) > > And no, it doesn't really matter as we fail in the patch version check > so maybe only a comment

Re: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-08 Thread Borislav Petkov
On Wed, Aug 07, 2013 at 11:34:01PM +, Yu, Fenghua wrote: > > This check won't work when CPU0 is hot added. So we need to find a > > better way to fix this. > > > > Maybe need to change the check as follows to take care of CPU0 hot add case? > > if ((cpu && system_state == SYSTEM_BOOTING) ||

Re: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-08 Thread Borislav Petkov
On Wed, Aug 07, 2013 at 07:22:39PM -0700, H. Peter Anvin wrote: > How much does this matter? I know what you're asking :-) And no, it doesn't really matter as we fail in the patch version check so maybe only a comment will suffice here so that people don't get confused. -- Regards/Gruss, Bo

RE: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-07 Thread H. Peter Anvin
How much does this matter? "Yu, Fenghua" wrote: >> From: Yu, Fenghua >> Sent: Wednesday, August 07, 2013 3:46 PM >> >> > From: Borislav Petkov [mailto:b...@alien8.de] >> > Sent: Wednesday, July 24, 2013 6:33 AM >> > On Tue, Jul 23, 2013 at 11:00:26PM +0200, Torsten Kaiser wrote: >> > > Extract c

RE: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-07 Thread Yu, Fenghua
> From: Yu, Fenghua > Sent: Wednesday, August 07, 2013 3:46 PM > > > From: Borislav Petkov [mailto:b...@alien8.de] > > Sent: Wednesday, July 24, 2013 6:33 AM > > On Tue, Jul 23, 2013 at 11:00:26PM +0200, Torsten Kaiser wrote: > > > Extract common checks and initialisations from load_ucode_ap() and

RE: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-08-07 Thread Yu, Fenghua
> From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, July 24, 2013 6:33 AM > On Tue, Jul 23, 2013 at 11:00:26PM +0200, Torsten Kaiser wrote: > > Extract common checks and initialisations from load_ucode_ap() and > > save_microcode_in_initrd_amd() to load_microcode_amd_early(). > > loa

Re: [PATCH 3/5] x86, AMD: cleanup: merge common code in early microcode loading

2013-07-24 Thread Borislav Petkov
On Tue, Jul 23, 2013 at 11:00:26PM +0200, Torsten Kaiser wrote: > Extract common checks and initialisations from load_ucode_ap() and > save_microcode_in_initrd_amd() to load_microcode_amd_early(). > load_ucode_ap() gets a quick exit for !cpu, because for the BSP there is > already a different funct