Re: [PATCH 3/6] efivars: efivar_entry API

2013-04-11 Thread Matt Fleming
On 10/04/13 16:25, Seiji Aguchi wrote: >> +if (efi_guidcmp(entry->var.VendorGuid, vendor)) >> +return 0; >> + >> +for (i = 0; i < DUMP_NAME_LEN; i++) >> +name[i] = entry->var.VariableName[i]; >> + >> +if (sscanf(name, "dump-type%u-%u-%d-%lu", >> + c

RE: [PATCH 3/6] efivars: efivar_entry API

2013-04-10 Thread Seiji Aguchi
> -static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, > -int *count, struct timespec *timespec, > -char **buf, struct pstore_info *psi) > +struct pstore_read_data { > + u64 *id; > + enum pstore_type_id *type; > + in