Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Fri, Jul 17, 2015 at 04:47:26PM +0100, Mark Rutland wrote: > On Fri, Jul 17, 2015 at 04:03:36PM +0100, Liang, Kan wrote: > > > > > > On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: > > > > From: Kan Liang > > > > > > > > Using is_hardware_event to replace

Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Fri, Jul 17, 2015 at 04:03:36PM +0100, Liang, Kan wrote: > > > > On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: > > > From: Kan Liang > > > > > > Using is_hardware_event to replace !is_software_event to indicate a > > > hardware event. > > > > Why...? > > First, the

RE: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Liang, Kan
> > On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Using is_hardware_event to replace !is_software_event to indicate a > > hardware event. > > Why...? First, the comments of is_software_event is not correct. 0 or !is_software_event is not for

Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: > From: Kan Liang > > Using is_hardware_event to replace !is_software_event to indicate a > hardware event. Why...? For an uncore event e, is_hardware_event(e) != !is_software_event(e), so this will be a change of

RE: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Liang, Kan
On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com Using is_hardware_event to replace !is_software_event to indicate a hardware event. Why...? First, the comments of is_software_event is not correct. 0 or !is_software_event is

Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Fri, Jul 17, 2015 at 04:47:26PM +0100, Mark Rutland wrote: On Fri, Jul 17, 2015 at 04:03:36PM +0100, Liang, Kan wrote: On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com Using is_hardware_event to replace

Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Fri, Jul 17, 2015 at 04:03:36PM +0100, Liang, Kan wrote: On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com Using is_hardware_event to replace !is_software_event to indicate a hardware event. Why...? First, the

Re: [PATCH 3/9] perf/x86: Add is_hardware_event

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:45PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com Using is_hardware_event to replace !is_software_event to indicate a hardware event. Why...? For an uncore event e, is_hardware_event(e) != !is_software_event(e), so this will be a change