RE: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t

2017-11-24 Thread Reshetova, Elena
> On Fri, Nov 24, 2017 at 08:29:42AM +, Reshetova, Elena wrote: > > By looking at the code, I don't see where the change in the reference > > counting > > could have caused this. > > The cause was the bug I identified in patch 3, not this patch. Oh, ok, because I could not figure an issue wi

Re: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t

2017-11-24 Thread Alasdair G Kergon
On Fri, Nov 24, 2017 at 08:29:42AM +, Reshetova, Elena wrote: > By looking at the code, I don't see where the change in the reference counting > could have caused this. The cause was the bug I identified in patch 3, not this patch. The regression is easily hit - tables that reference the sa

RE: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t

2017-11-24 Thread Reshetova, Elena
> Dne 20.10.2017 v 09:37 Elena Reshetova napsal(a): > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set() > > - a resource is freed upon counter reaching zero > > - once counter reache

Re: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t

2017-11-23 Thread Zdenek Kabelac
Dne 20.10.2017 v 09:37 Elena Reshetova napsal(a): atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further