Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-17 Thread Oscar Salvador
On Mon, Jun 17, 2019 at 05:57:16PM +1000, Alastair D'Silva wrote: > I was getting stalls when removing ~1TB of memory. Would you mind sharing one of those stalls-splats? I am bit spectic here because as I Michal pointed out, we do cond_resched once per section removed. -- Oscar Salvador SUSE L3

Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-17 Thread Michal Hocko
Jiri Kosina ; linux- > > ker...@vger.kernel.org > > Subject: Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large > > amounts of memory > > > > On Mon 17-06-19 14:36:30, Alastair D'Silva wrote: > > > From: Alastair D'Silva > &g

RE: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-17 Thread Alastair D'Silva
Thomas Gleixner ; Andrew Morton > ; Mike Rapoport ; > Baoquan He ; David Hildenbrand ; > Josh Poimboeuf ; Pavel Tatashin > ; Juergen Gross ; Oscar > Salvador ; Jiri Kosina ; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing la

Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-17 Thread Michal Hocko
On Mon 17-06-19 14:36:30, Alastair D'Silva wrote: > From: Alastair D'Silva > > When removing sufficiently large amounts of memory, we trigger RCU stall > detection. By periodically calling cond_resched(), we avoid bogus stall > warnings. > > Signed-off-by: Alastair D'Silva > --- > mm/memory_

Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-16 Thread Alastair D'Silva
On Mon, 2019-06-17 at 09:53 +0300, Mike Rapoport wrote: > On Mon, Jun 17, 2019 at 02:36:30PM +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > When removing sufficiently large amounts of memory, we trigger RCU > > stall > > detection. By periodically calling cond_resched(), we avo

Re: [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory

2019-06-16 Thread Mike Rapoport
On Mon, Jun 17, 2019 at 02:36:30PM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > When removing sufficiently large amounts of memory, we trigger RCU stall > detection. By periodically calling cond_resched(), we avoid bogus stall > warnings. > > Signed-off-by: Alastair D'Silva > ---