Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 10:40:34AM -0400, Sasha Levin wrote: > On Wed, Oct 17, 2018 at 04:26:21PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 17, 2018 at 02:15:30PM +, Haiyang Zhang wrote: > > > The VF NIC needs to be paired with synthetic NIC on HyperV -- to do > > > that we > > > use

Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Sasha Levin
On Wed, Oct 17, 2018 at 04:26:21PM +0200, Greg Kroah-Hartman wrote: On Wed, Oct 17, 2018 at 02:15:30PM +, Haiyang Zhang wrote: The VF NIC needs to be paired with synthetic NIC on HyperV -- to do that we use MAC address matching before the patch #A. But a non VF NIC can also have the same M

Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Greg Kroah-Hartman
org; Stephen Hemminger > > ; David S. Miller ; Sasha > > Levin > > Subject: Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number > > > > On Wed, Oct 17, 2018 at 01:02:17PM +, Haiyang Zhang wrote: > > > > > > > > > > -Ori

RE: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Haiyang Zhang
Haiyang Zhang > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Stephen > > > Hemminger ; David S. Miller > > > ; Sasha Levin > > > Subject: Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial > > > number > > > > > &

Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Sasha Levin
On Wed, Oct 17, 2018 at 09:46:29AM +0200, Greg Kroah-Hartman wrote: Also, this really feels like a "new feature" to me. Can someone explain what bug this is fixing? Reading the commit log/code it seems that it was possible for 2 (or more) synthetic devices to have the same MAC address even tho

Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Greg Kroah-Hartman
org; Stephen Hemminger > > ; David S. Miller ; Sasha > > Levin > > Subject: Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number > > > > On Tue, Oct 16, 2018 at 07:13:12PM +, Haiyang Zhang wrote: > > > > > > > > > > -Ori

RE: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Haiyang Zhang
> -Original Message- > From: Greg Kroah-Hartman > Sent: Wednesday, October 17, 2018 3:46 AM > To: Haiyang Zhang > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Stephen Hemminger > ; David S. Miller ; Sasha > Levin > Subject: Re: [PATCH 4.18 101

Re: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 16, 2018 at 07:13:12PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Greg Kroah-Hartman > > Sent: Tuesday, October 16, 2018 1:06 PM > > To: linux-kernel@vger.kernel.org > > Cc: Greg Kr

RE: [PATCH 4.18 101/135] hv_netvsc: pair VF based on serial number

2018-10-16 Thread Haiyang Zhang
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Greg Kroah-Hartman > Sent: Tuesday, October 16, 2018 1:06 PM > To: linux-kernel@vger.kernel.org > Cc: Greg Kroah-Hartman ; > sta...@vger.kernel.org; Stephen Hemminger ; > David S. Miller ;