Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-22 Thread Or Gerlitz
On Thu, May 23, 2013 at 12:40 AM, Don Dutile wrote: > On 05/22/2013 04:16 PM, Or Gerlitz wrote: [...] >> Hi Alex, all, so to clarify: >> >> 1. currently due to current firmware limitation we must call >> pci_enable_sriov before the >> PF ends its initialization sequence done in the PCI probe call

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-22 Thread Or Gerlitz
On Thu, May 23, 2013 at 2:45 AM, Ben Hutchings wrote: > On Wed, 2013-05-22 at 23:16 +0300, Or Gerlitz wrote: > [...] >> all in all, we will look into returning -EPROBE_DEFER from the VF >> when they identify the problematic situation -- so for how much time >> this is deferred? or if this isn't t

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-22 Thread Ben Hutchings
On Wed, 2013-05-22 at 23:16 +0300, Or Gerlitz wrote: [...] > all in all, we will look into returning -EPROBE_DEFER from the VF > when they identify the problematic situation -- so for how much time > this is deferred? or if this isn't time based what the logical > condition which once met the VF p

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-22 Thread Don Dutile
On 05/22/2013 04:16 PM, Or Gerlitz wrote: On Wed, May 22, 2013 at 1:30 AM, Alexander Duyck wrote: On 05/21/2013 03:11 PM, Michael S. Tsirkin wrote: On Tue, May 21, 2013 at 03:01:08PM -0700, Alexander Duyck wrote: On 05/21/2013 02:49 PM, Michael S. Tsirkin wrote: On Tue, May 21, 2013 at 05:3

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-22 Thread Or Gerlitz
On Wed, May 22, 2013 at 1:30 AM, Alexander Duyck wrote: > On 05/21/2013 03:11 PM, Michael S. Tsirkin wrote: >> On Tue, May 21, 2013 at 03:01:08PM -0700, Alexander Duyck wrote: >>> On 05/21/2013 02:49 PM, Michael S. Tsirkin wrote: On Tue, May 21, 2013 at 05:30:32PM -0400, Don Dutile wrote: >>>

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Alexander Duyck
On 05/21/2013 03:11 PM, Michael S. Tsirkin wrote: > On Tue, May 21, 2013 at 03:01:08PM -0700, Alexander Duyck wrote: >> On 05/21/2013 02:49 PM, Michael S. Tsirkin wrote: >>> On Tue, May 21, 2013 at 05:30:32PM -0400, Don Dutile wrote: On 05/14/2013 05:39 PM, Alexander Duyck wrote: > On 05/1

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Alexander Duyck
On 05/21/2013 03:09 PM, Don Dutile wrote: > On 05/21/2013 05:58 PM, Alexander Duyck wrote: >> On 05/21/2013 02:31 PM, Don Dutile wrote: >>> On 05/21/2013 05:30 PM, Don Dutile wrote: On 05/14/2013 05:39 PM, Alexander Duyck wrote: > On 05/14/2013 12:59 PM, Yinghai Lu wrote: >> On Tue, Ma

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2013 at 03:01:08PM -0700, Alexander Duyck wrote: > On 05/21/2013 02:49 PM, Michael S. Tsirkin wrote: > > On Tue, May 21, 2013 at 05:30:32PM -0400, Don Dutile wrote: > >> On 05/14/2013 05:39 PM, Alexander Duyck wrote: > >>> On 05/14/2013 12:59 PM, Yinghai Lu wrote: > On Tue, May

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Don Dutile
On 05/21/2013 05:58 PM, Alexander Duyck wrote: On 05/21/2013 02:31 PM, Don Dutile wrote: On 05/21/2013 05:30 PM, Don Dutile wrote: On 05/14/2013 05:39 PM, Alexander Duyck wrote: On 05/14/2013 12:59 PM, Yinghai Lu wrote: On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: On 05/14/2013

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Alexander Duyck
On 05/21/2013 02:49 PM, Michael S. Tsirkin wrote: > On Tue, May 21, 2013 at 05:30:32PM -0400, Don Dutile wrote: >> On 05/14/2013 05:39 PM, Alexander Duyck wrote: >>> On 05/14/2013 12:59 PM, Yinghai Lu wrote: On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: > On 05/14/2013 11

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Alexander Duyck
On 05/21/2013 02:31 PM, Don Dutile wrote: > On 05/21/2013 05:30 PM, Don Dutile wrote: >> On 05/14/2013 05:39 PM, Alexander Duyck wrote: >>> On 05/14/2013 12:59 PM, Yinghai Lu wrote: On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: > On 05/14/2013 11:44 AM, Yinghai Lu wrote: >

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2013 at 05:30:32PM -0400, Don Dutile wrote: > On 05/14/2013 05:39 PM, Alexander Duyck wrote: > >On 05/14/2013 12:59 PM, Yinghai Lu wrote: > >>On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck > >> wrote: > >>>On 05/14/2013 11:44 AM, Yinghai Lu wrote: > On Tue, May 14, 2013 at 9

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Don Dutile
On 05/21/2013 05:30 PM, Don Dutile wrote: On 05/14/2013 05:39 PM, Alexander Duyck wrote: On 05/14/2013 12:59 PM, Yinghai Lu wrote: On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: On 05/14/2013 11:44 AM, Yinghai Lu wrote: On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck wrote: I'm

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-21 Thread Don Dutile
On 05/14/2013 05:39 PM, Alexander Duyck wrote: On 05/14/2013 12:59 PM, Yinghai Lu wrote: On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: On 05/14/2013 11:44 AM, Yinghai Lu wrote: On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck wrote: I'm sorry, but what is the point of this patc

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Or Gerlitz
On Thu, May 16, 2013 at 9:36 PM, Yinghai Lu wrote: > On Thu, May 16, 2013 at 10:53 AM, Tejun Heo wrote: >> On Thu, May 16, 2013 at 12:56:42AM -0400, Or Gerlitz wrote: > Please note that this whole lockdep warning was identified as false > positive by Tejun http://www.spinics.net/lists/li

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-16 Thread Yinghai Lu
On Thu, May 16, 2013 at 10:53 AM, Tejun Heo wrote: > On Thu, May 16, 2013 at 12:56:42AM -0400, Or Gerlitz wrote: >> > > Please note that this whole lockdep warning was identified as false >> > > positive by Tejun http://www.spinics.net/lists/linux-pci/msg21568.html >> > >> > No, at least one time,

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-16 Thread Tejun Heo
On Thu, May 16, 2013 at 12:56:42AM -0400, Or Gerlitz wrote: > > > Please note that this whole lockdep warning was identified as false > > > positive by Tejun http://www.spinics.net/lists/linux-pci/msg21568.html > > > > No, at least one time, I noticed there is one real hang happens. > > Tejun, so

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-15 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 07:28:25PM -0700, Yinghai Lu wrote: > Found kernel try to load mlx4 drivers for VFs before > PF's is really loaded when the drivers are built-in, and kernel > command line include probe_vfs=63, num_vfs=63. > > It turns that it also happen for hotadd path even drivers are >

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-15 Thread Or Gerlitz
On Thu, May 16, 2013 at 12:39 AM, Yinghai Lu wrote: > > On Wed, May 15, 2013 at 9:00 PM, Or Gerlitz wrote: > > On Tue, May 14, 2013 at 11:43 AM, Yinghai Lu wrote: > > > >> BTW, do you have any plan to make mlx4 support sriov_configure via > >> sysfs? > > > > yes we do, we're waiting for a firmwa

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-15 Thread Yinghai Lu
On Wed, May 15, 2013 at 9:00 PM, Or Gerlitz wrote: > On Tue, May 14, 2013 at 11:43 AM, Yinghai Lu wrote: > >> BTW, do you have any plan to make mlx4 support sriov_configure via sysfs? > > yes we do, we're waiting for a firmware change that will allow for > such a patch to get working. > > Please

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-15 Thread Or Gerlitz
On Tue, May 14, 2013 at 11:43 AM, Yinghai Lu wrote: > BTW, do you have any plan to make mlx4 support sriov_configure via sysfs? yes we do, we're waiting for a firmware change that will allow for such a patch to get working. Please note that this whole lockdep warning was identified as false pos

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Alexander Duyck
On 05/14/2013 12:59 PM, Yinghai Lu wrote: > On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck > wrote: >> On 05/14/2013 11:44 AM, Yinghai Lu wrote: >>> On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck >>> wrote: I'm sorry, but what is the point of this patch? With device assignment it

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 12:45 PM, Alexander Duyck wrote: > On 05/14/2013 11:44 AM, Yinghai Lu wrote: >> On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck >> wrote: >>> I'm sorry, but what is the point of this patch? With device assignment >>> it is always possible to have VFs loaded and the PF d

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Alexander Duyck
On 05/14/2013 11:44 AM, Yinghai Lu wrote: > On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck > wrote: >> On 05/13/2013 07:28 PM, Yinghai Lu wrote: >>> Found kernel try to load mlx4 drivers for VFs before >>> PF's is really loaded when the drivers are built-in, and kernel >>> command line include p

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 9:00 AM, Alexander Duyck wrote: > On 05/13/2013 07:28 PM, Yinghai Lu wrote: >> Found kernel try to load mlx4 drivers for VFs before >> PF's is really loaded when the drivers are built-in, and kernel >> command line include probe_vfs=63, num_vfs=63. >> >> It turns that it al

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Alexander Duyck
On 05/13/2013 07:28 PM, Yinghai Lu wrote: > Found kernel try to load mlx4 drivers for VFs before > PF's is really loaded when the drivers are built-in, and kernel > command line include probe_vfs=63, num_vfs=63. > > It turns that it also happen for hotadd path even drivers are > compiled as modules

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 1:58 AM, Yan Burman wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Yinghai Lu >> Sent: Tuesday, May 14, 2013 05:31 >> To: Bjorn Helgaas >> Cc: Gu Zheng; linux-...@vger.kernel.org; linux-ke

Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 2:46 AM, Perla, Sathya wrote: > >> -Original Message- >> From: linux-pci-ow...@vger.kernel.org [mailto:linux-pci- >> ow...@vger.kernel.org] On Behalf Of Yinghai Lu >> >> Found kernel try to load mlx4 drivers for VFs before PF's is really loaded >> when the drivers a

RE: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Perla, Sathya
> -Original Message- > From: linux-pci-ow...@vger.kernel.org [mailto:linux-pci- > ow...@vger.kernel.org] On Behalf Of Yinghai Lu > > Found kernel try to load mlx4 drivers for VFs before PF's is really loaded > when the drivers are built-in, and kernel command line include > probe_vfs=63,

RE: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yan Burman
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Yinghai Lu > Sent: Tuesday, May 14, 2013 05:31 > To: Bjorn Helgaas > Cc: Gu Zheng; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Yinghai > Lu; net...@vger.kernel.org >