RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > From: Corey

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015 09:54 PM, 河合英宏 /

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > From: Corey

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will break ATN handling

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> This patch will break ATN handling on the interfaces. So we can't do

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> This patch will break ATN handling on the interfaces. So we can't do this. > I understand. So how about doing like this: > > /* All states wait for ibf,

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will break ATN handling on the interfaces. So we can't do this. I

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will break ATN handling on the interfaces. So we can't do this. I understand. So how about doing like this: /* All states wait for ibf, so just

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > This patch will break ATN handling on the interfaces. So we can't do this. I understand. So how about doing like this: /* All states wait for ibf, so just do it here. */ - if (!check_ibf(kcs,

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will break ATN handling on the interfaces. So we can't do this. I understand. So how about doing like this: /* All states wait for ibf, so just do it here. */ - if (!check_ibf(kcs, status,

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

This patch will break ATN handling on the interfaces. So we can't do this. It's going to be extremely hard to recover if the BMC is not working correctly when a panic happens. I'm not sure what can be done, but if you can fix it another way it would be good. -corey On 07/27/2015 12:55 AM,

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

This patch will break ATN handling on the interfaces. So we can't do this. It's going to be extremely hard to recover if the BMC is not working correctly when a panic happens. I'm not sure what can be done, but if you can fix it another way it would be good. -corey On 07/27/2015 12:55 AM,