RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-28 Thread Venkat Venkatsubra
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, October 27, 2013 11:27 PM To: b...@decadent.org.uk Cc: Venkat Venkatsubra; linux-kernel@vger.kernel.org; rds-de...@oss.oracle.com; net...@vger.kernel.org Subject: Re: [PATCH 7/8] rds: Pass pointers

RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-28 Thread Venkat Venkatsubra
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, October 27, 2013 11:27 PM To: b...@decadent.org.uk Cc: Venkat Venkatsubra; linux-kernel@vger.kernel.org; rds-de...@oss.oracle.com; net...@vger.kernel.org Subject: Re: [PATCH 7/8] rds: Pass pointers

Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-27 Thread David Miller
From: Ben Hutchings Date: Sun, 27 Oct 2013 21:54:16 + > Most architectures define virt_to_page() as a macro that casts its > argument such that an argument of type unsigned long will be accepted > without complaint. However, the proper type is void *, and passing > unsigned long results in

Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-27 Thread David Miller
From: Ben Hutchings b...@decadent.org.uk Date: Sun, 27 Oct 2013 21:54:16 + Most architectures define virt_to_page() as a macro that casts its argument such that an argument of type unsigned long will be accepted without complaint. However, the proper type is void *, and passing unsigned