On Mon, 2008-01-21 at 13:45 +0800, Li Zefan wrote:
> >>> +static int __init intel_menlow_module_init(void)
> >>> +{
> >>> + int result = -ENODEV;
> >>> + acpi_status status;
> >>> + unsigned long enable;
> >>> +
> >>> + if (acpi_disabled)
> >>> + return result;
> >>> +
> >>> +
On Monday 21 January 2008 04:53, Christoph Hellwig wrote:
> On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> > From: Thomas Sujith <[EMAIL PROTECTED]>
> >
> > Intel menlow platform specific driver for thermal management.
> >
> > Signed-off-by: Thomas Sujith <[EMAIL PROTECTED]>
> > Sig
On Jan 21 2008 19:49, Thomas, Sujith wrote:
>>>
>>> +MODULE_AUTHOR("Thomas Sujith");
>>> +MODULE_AUTHOR("Zhang Rui");
>>
>> I've never seen a driver with two MODULE_AUTHOR statements before.
>> Does this actually work? What does modinfo -F author say for your module?
>
>There is nothing wrong i
ject: Re: [PATCH 9/10] introduce intel_menlow platform specific
driver
>
> On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> > From: Thomas Sujith <[EMAIL PROTECTED]>
> >
> > Intel menlow platform specific driver for thermal management.
> >
> > Sig
On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> From: Thomas Sujith <[EMAIL PROTECTED]>
>
> Intel menlow platform specific driver for thermal management.
>
> Signed-off-by: Thomas Sujith <[EMAIL PROTECTED]>
> Signed-off-by: Zhang Rui <[EMAIL PROTECTED]>
> ---
> drivers/misc/Kconfig
>>> +static int __init intel_menlow_module_init(void)
>>> +{
>>> + int result = -ENODEV;
>>> + acpi_status status;
>>> + unsigned long enable;
>>> +
>>> + if (acpi_disabled)
>>> + return result;
>>> +
>>> + /* Looking for the \_TZ.GSTS method */
>>> + status = acpi_evaluate_in
Sujith
> Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver
>
> Zhang Rui 写道:
> > Hi, Randy and Sam,
> >
> >>> + if (result)
> >>> + goto end;acpi_bus_get_private_data
> >>> + }
> >
Zhang Rui 写道:
> Hi, Randy and Sam,
>
>>> + if (result)
>>> + goto end;acpi_bus_get_private_data
>>> + }
>>> +
>>> + end:
> Hah, Lindent always does this for me,
>> Labels should begin in column 0 or 1. Only.
> yes, and checkpatch.pl begins to complain abou
Hi, Randy and Sam,
> > + if (result)
> > + goto end;
> > + }
> > +
> > + end:
Hah, Lindent always does this for me,
> Labels should begin in column 0 or 1. Only.
yes, and checkpatch.pl begins to complain about this
after using Lindent...
I think we should
Len Brown wrote:
+static int
+memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev,
+unsigned long *max_state)
Don't put 'static int' (return type etc.) on a line by itself.
That format is not wanted in Linux. (many places here)
if checkpatch.pl and Li
> > +static int
> > +memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev,
> > +unsigned long *max_state)
>
> Don't put 'static int' (return type etc.) on a line by itself.
> That format is not wanted in Linux. (many places here)
if checkpatch.pl and Lindent
On Thu, 17 Jan 2008 15:51:17 +0800 Zhang Rui wrote:
> From: Thomas Sujith <[EMAIL PROTECTED]>
>
> Intel menlow platform specific driver for thermal management.
>
> Signed-off-by: Thomas Sujith <[EMAIL PROTECTED]>
> Signed-off-by: Zhang Rui <[EMAIL PROTECTED]>
> ---
> drivers/misc/Kconfig
>
> +config INTEL_MENLOW
> +tristate "Thermal Management driver for Intel menlow platform"
> +depends on ACPI_THERMAL
> + default n
default n is not needed - it is default.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
13 matches
Mail list logo
