RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-30 Thread zhangheng (AC)
Chenhaibo (Haibo, OS Lab) ><hb.c...@huawei.com>; lihao.li...@gmail.com; linux-kernel@vger.kernel.org >Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Tue, Jan 30, 2018 at 05:34:03AM +, zhangheng (AC) wrote: >[...] >> >> > +static void prcu_

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-30 Thread zhangheng (AC)
t;Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Tue, Jan 30, 2018 at 05:34:03AM +, zhangheng (AC) wrote: >[...] >> >> > +static void prcu_handler(void *info) { >> >> > + struct prcu_local_struct *local; >> >> >

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread Boqun Feng
On Tue, Jan 30, 2018 at 05:34:03AM +, zhangheng (AC) wrote: [...] > >> > +static void prcu_handler(void *info) { > >> > +struct prcu_local_struct *local; > >> > + > >> > +local = this_cpu_ptr(_local); > >> > +if (!local->locked) > > > >And I think a smp_mb() is needed

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread Boqun Feng
On Tue, Jan 30, 2018 at 05:34:03AM +, zhangheng (AC) wrote: [...] > >> > +static void prcu_handler(void *info) { > >> > +struct prcu_local_struct *local; > >> > + > >> > +local = this_cpu_ptr(_local); > >> > +if (!local->locked) > > > >And I think a smp_mb() is needed

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
awei.com>; zhangheng (AC) <hen...@huawei.com>; Chenhaibo (Haibo, >OS Lab) <hb.c...@huawei.com>; lihao.li...@gmail.com; LKML ><linux-kernel@vger.kernel.org> >Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Tue, Jan 23, 2018 at 3:59 PM, <

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
ao.li...@gmail.com; LKML > >Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Tue, Jan 23, 2018 at 3:59 PM, wrote: >> From: Heng Zhang >> >> This RCU implementation (PRCU) is based on a fast consensus protocol >> published in the following pape

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
Chenhaibo (Haibo, OS Lab) ><hb.c...@huawei.com>; lihao.li...@gmail.com; linux-kernel@vger.kernel.org >Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Wed, Jan 24, 2018 at 10:16:18PM -0800, Paul E. McKenney wrote: >> On Tue, Jan 23, 2018 at 03:59:26PM +0800

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
t;Subject: Re: [PATCH RFC 01/16] prcu: Add PRCU implementation > >On Wed, Jan 24, 2018 at 10:16:18PM -0800, Paul E. McKenney wrote: >> On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: >> > From: Heng Zhang >> > >> > This RCU

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
lt;guohan...@huawei.com>; Chenhaibo (Haibo, OS Lab) <hb.c...@huawei.com>; lihao.li...@gmail.com; linux-kernel@vger.kernel.org Subject: RE: [PATCH RFC 01/16] prcu: Add PRCU implementation Hi Paul, thanks a lot for pointing out the problems of the implementation. Here's my understanding.

RE: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread zhangheng (AC)
) ; lihao.li...@gmail.com; linux-kernel@vger.kernel.org Subject: RE: [PATCH RFC 01/16] prcu: Add PRCU implementation Hi Paul, thanks a lot for pointing out the problems of the implementation. Here's my understanding. Best Regards, Heng -Original Message- >From: Paul E. McKenney [mailto:p

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread Lai Jiangshan
On Tue, Jan 23, 2018 at 3:59 PM, wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly >

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-29 Thread Lai Jiangshan
On Tue, Jan 23, 2018 at 3:59 PM, wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly > Synchronization. > Haibo Chen, Heng Zhang, Ran Liu,

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-26 Thread Lihao Liang
On Thu, Jan 25, 2018 at 6:16 AM, Paul E. McKenney wrote: > On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: >> From: Heng Zhang >> >> This RCU implementation (PRCU) is based on a fast consensus protocol >> published in the

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-26 Thread Lihao Liang
On Thu, Jan 25, 2018 at 6:16 AM, Paul E. McKenney wrote: > On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: >> From: Heng Zhang >> >> This RCU implementation (PRCU) is based on a fast consensus protocol >> published in the following paper: >> >> Fast Consensus Using Bounded

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Boqun Feng
On Wed, Jan 24, 2018 at 10:16:18PM -0800, Paul E. McKenney wrote: > On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > > From: Heng Zhang > > > > This RCU implementation (PRCU) is based on a fast consensus protocol > > published in the following paper: >

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Boqun Feng
On Wed, Jan 24, 2018 at 10:16:18PM -0800, Paul E. McKenney wrote: > On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > > From: Heng Zhang > > > > This RCU implementation (PRCU) is based on a fast consensus protocol > > published in the following paper: > > > > Fast

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Paul E. McKenney
On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly >

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Paul E. McKenney
On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly > Synchronization. > Haibo

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Peter Zijlstra
On Wed, Jan 24, 2018 at 05:15:30PM +, Lihao Liang wrote: > Alternatively, the paper can be found at > > http://ipads.se.sjtu.edu.cn/lib/exe/fetch.php?media=publications:consensus-tpds16.pdf Thanks, I'll try and have a read.

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Peter Zijlstra
On Wed, Jan 24, 2018 at 05:15:30PM +, Lihao Liang wrote: > Alternatively, the paper can be found at > > http://ipads.se.sjtu.edu.cn/lib/exe/fetch.php?media=publications:consensus-tpds16.pdf Thanks, I'll try and have a read.

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Lihao Liang
Dear Peter, Many thanks for your comments. I will provide a proper changelog. Alternatively, the paper can be found at http://ipads.se.sjtu.edu.cn/lib/exe/fetch.php?media=publications:consensus-tpds16.pdf Best, Lihao. On Wed, Jan 24, 2018 at 11:26 AM, Peter Zijlstra

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Lihao Liang
Dear Peter, Many thanks for your comments. I will provide a proper changelog. Alternatively, the paper can be found at http://ipads.se.sjtu.edu.cn/lib/exe/fetch.php?media=publications:consensus-tpds16.pdf Best, Lihao. On Wed, Jan 24, 2018 at 11:26 AM, Peter Zijlstra wrote: > On Tue, Jan 23,

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Peter Zijlstra
On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly >

Re: [PATCH RFC 01/16] prcu: Add PRCU implementation

2018-01-24 Thread Peter Zijlstra
On Tue, Jan 23, 2018 at 03:59:26PM +0800, liangli...@huawei.com wrote: > From: Heng Zhang > > This RCU implementation (PRCU) is based on a fast consensus protocol > published in the following paper: > > Fast Consensus Using Bounded Staleness for Scalable Read-mostly > Synchronization. > Haibo