Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-11-05 Thread Christian Schoenebeck
On Mittwoch, 4. November 2020 12:57:08 CET Dominique Martinet wrote: > Christian Schoenebeck wrote on Wed, Nov 04, 2020: > > > Greg, Christian - from what I understood (in private, hopefully I'm > > > allowed to repeat!), he won't be able to contribute to qemu because of > > > company policies and

RE: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-11-04 Thread Jianyong Wu
om; lu...@ionkov.net; qemu_...@crudebyte.com; > gr...@kaod.org; v9fs-develo...@lists.sourceforge.net; linux- > ker...@vger.kernel.org; Justin He > Subject: Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention. > > Jianyong, > > Jianyong Wu wrote on Wed, Sep 23, 2020: > &g

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-11-04 Thread Christian Schoenebeck
On Dienstag, 3. November 2020 11:41:16 CET Dominique Martinet wrote: > Jianyong, > > Jianyong Wu wrote on Wed, Sep 23, 2020: > > Eric's and Greg's patch offer a mechanism to fix open-unlink-f*syscall > > bug in 9p. But there is race issue in fid comtention. > > As Greg's patch stores all of fids f

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-11-04 Thread Dominique Martinet
Christian Schoenebeck wrote on Wed, Nov 04, 2020: > > Greg, Christian - from what I understood (in private, hopefully I'm > > allowed to repeat!), he won't be able to contribute to qemu because of > > company policies and I'm unlikely to take the time either right now. > > I don't think it's a prob

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-11-03 Thread Dominique Martinet
Jianyong, Jianyong Wu wrote on Wed, Sep 23, 2020: > Eric's and Greg's patch offer a mechanism to fix open-unlink-f*syscall > bug in 9p. But there is race issue in fid comtention. > As Greg's patch stores all of fids from opened files into according inode, > so all the lookup fid ops can retrieve f

RE: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-09-25 Thread Jianyong Wu
er.kernel.org; Justin He > Subject: Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention. > > Jianyong Wu wrote on Thu, Sep 24, 2020: > > > Jianyong Wu wrote on Wed, Sep 23, 2020: > > > > open-unlink-f*syscall test: > > > > I have tested f

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-09-24 Thread Dominique Martinet
Jianyong Wu wrote on Thu, Sep 24, 2020: > > Jianyong Wu wrote on Wed, Sep 23, 2020: > > > open-unlink-f*syscall test: > > > I have tested for f*syscall include: ftruncate fstat fchown fchmod > > > faccessat. > > > > Given the other thread, what did you test this with? > > Er, I just use Greg's qem

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-09-24 Thread Greg Kurz
On Thu, 24 Sep 2020 08:38:01 + Jianyong Wu wrote: > > Given the other thread, what did you test this with? > Er, I just use Greg's qemu of https://github.com/gkurz/qemu.git: > 9p-attr-fixes. I should have referenced it in commit message. ... which is a pretty old QEMU version BTW. https:

RE: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-09-24 Thread Jianyong Wu
er...@vger.kernel.org; Justin He > Subject: Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention. > > > Overall looks good; a few comments. Thanks > > Jianyong Wu wrote on Wed, Sep 23, 2020: > > open-unlink-f*syscall test: > > I have tested for f*syscall include: ftru

Re: [PATCH RFC v2 4/4] 9p: fix race issue in fid contention.

2020-09-23 Thread Dominique Martinet
Overall looks good; a few comments. Jianyong Wu wrote on Wed, Sep 23, 2020: > open-unlink-f*syscall test: > I have tested for f*syscall include: ftruncate fstat fchown fchmod faccessat. Given the other thread, what did you test this with? Since qemu doesn't work apparently do you have a in-hous